Better --check compatibility for ceph-rgw role

Carefully chosen "always_run: true" parameters for read-only tasks that
register variables. This enables --check runs (at least on deployed
clusters).

diff --git a/roles/ceph-rgw/tasks/docker/checks.yml b/roles/ceph-rgw/tasks/docker/checks.yml
index 09cb57b577440d923c8b11179af952b01e8cca31..968fc038cf215e407ccfce9386f44280021686b9 100644 (file)
--- a/roles/ceph-rgw/tasks/docker/checks.yml
+++ b/roles/ceph-rgw/tasks/docker/checks.yml
@@ -16,6 +16,7 @@
   with_items: "{{ ceph_config_keys }}"
   changed_when: false
   failed_when: false
+  always_run: true
   register: statleftover
 
 - name: fail if we find existing cluster files

diff --git a/roles/ceph-rgw/tasks/docker/copy_configs.yml b/roles/ceph-rgw/tasks/docker/copy_configs.yml
index 10e7052202996d594ca5f642b46c84541a68b8f2..757648a2e78f141d2ff0e60239b99db47368be6f 100644 (file)
--- a/roles/ceph-rgw/tasks/docker/copy_configs.yml
+++ b/roles/ceph-rgw/tasks/docker/copy_configs.yml
@@ -17,6 +17,7 @@
   changed_when: false
   become: false
   failed_when: false
+  always_run: true
   register: statconfig
   when:
     - nfs_obj_gw

diff --git a/roles/ceph-rgw/tasks/docker/dirs_permissions.yml b/roles/ceph-rgw/tasks/docker/dirs_permissions.yml
index ccdf915fbb0a197b2adf716b91c151fbcfad944a..a80902a48c84171141704499b1cd7d8dd31d15ab 100644 (file)
--- a/roles/ceph-rgw/tasks/docker/dirs_permissions.yml
+++ b/roles/ceph-rgw/tasks/docker/dirs_permissions.yml
@@ -5,6 +5,7 @@
   shell: docker inspect "docker.io/{{ ceph_rgw_docker_username }}/{{ ceph_rgw_docker_imagename }}:{{ ceph_rgw_docker_image_tag }}" | awk -F '=' '/CEPH_VERSION/ { gsub ("\",", "", $2); print $2 }' | uniq
   changed_when: false
   failed_when: false
+  always_run: true
   run_once: true
   register: ceph_version
 

diff --git a/roles/ceph-rgw/tasks/docker/fetch_configs.yml b/roles/ceph-rgw/tasks/docker/fetch_configs.yml
index 19337240dfa2d01dea5c8472e3837f93f3d3a541..ee8b16e3ea3cb9e514bfe077aff072ebc2ceaf1e 100644 (file)
--- a/roles/ceph-rgw/tasks/docker/fetch_configs.yml
+++ b/roles/ceph-rgw/tasks/docker/fetch_configs.yml
@@ -11,6 +11,7 @@
   changed_when: false
   become: false
   ignore_errors: true
+  always_run: true
   register: statconfig
 
 - name: try to fetch ceph config and keys

diff --git a/roles/ceph-rgw/tasks/docker/main.yml b/roles/ceph-rgw/tasks/docker/main.yml
index 96de18281434fbdc1b4af973f4c48f442dd5b5ee..6fcb14abb9179ad925023afadc6d46f2a55fd761 100644 (file)
--- a/roles/ceph-rgw/tasks/docker/main.yml
+++ b/roles/ceph-rgw/tasks/docker/main.yml
@@ -4,9 +4,11 @@
   register: ceph_health
   changed_when: false
   failed_when: false
+  always_run: true
 
 - name: check if it is Atomic host
   stat: path=/run/ostree-booted
+  always_run: true
   register: stat_ostree
 
 - name: set fact for using Atomic host

diff --git a/roles/ceph-rgw/tasks/docker/selinux.yml b/roles/ceph-rgw/tasks/docker/selinux.yml
index 3630824d759a9aab7f7d69a96c52c9e4afb71dc5..6d4ee022f58272ad242b1234aa1e94f4b9ac6e27 100644 (file)
--- a/roles/ceph-rgw/tasks/docker/selinux.yml
+++ b/roles/ceph-rgw/tasks/docker/selinux.yml
@@ -3,6 +3,7 @@
   command: getenforce
   register: sestatus
   changed_when: false
+  always_run: true
 
 - name: set selinux permissions
   shell: chcon -Rt svirt_sandbox_file_t {{ item }}

diff --git a/roles/ceph-rgw/tasks/multisite/checks.yml b/roles/ceph-rgw/tasks/multisite/checks.yml
index 7bc6bbb8dd2ae5368151786ebd2d372e14b1c586..c8565b4221f316aa51daefb4bcce54f9730e9c53 100644 (file)
--- a/roles/ceph-rgw/tasks/multisite/checks.yml
+++ b/roles/ceph-rgw/tasks/multisite/checks.yml
@@ -4,21 +4,25 @@
   register: realmcheck
   failed_when: False
   changed_when: False
+  always_run: True
 
 - name: check if the zonegroup already exists
   command: radosgw-admin zonegroup get --rgw-zonegroup={{ rgw_zonegroup }}
   register: zonegroupcheck
   failed_when: False
   changed_when: False
+  always_run: True
 
 - name: check if the zone already exists
   command: radosgw-admin zone get --rgw-zone={{ rgw_zone }}
   register: zonecheck
   failed_when: False
   changed_when: False
+  always_run: True
 
 - name: check if the system user already exists
   command: radosgw-admin user info --uid=zone.user
   register: usercheck
   failed_when: False
   changed_when: False
+  always_run: True