]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
common/dump: don't replace pids arbitrarily
authorDarrick J. Wong <djwong@kernel.org>
Mon, 3 Feb 2025 22:00:26 +0000 (14:00 -0800)
committerZorro Lang <zlang@kernel.org>
Sun, 16 Feb 2025 11:25:57 +0000 (19:25 +0800)
In the next patch we'll run tests in a pid namespace, which means that
the test process will have a very low pid.  This low pid situation
causes problems with the dump tests because they unconditionally replace
it with the word "PID", which causes unnecessary test failures.

Initially I was going to fix it by bracketing the regexp with a
whitespace/punctuation/eol/sol detector, but then I decided to remove it
see how many sheep came barreling through.  None did, so I removed it
entirely.  The commit adding it (linked below) was not insightful at
all.

Fixes: 19beb54c96e363 ("Extra filtering as part of IRIX/Linux xfstests reconciliation for dump.")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
common/dump

index 3761c16100d808b901f375cf82b40243fd2cca1b..6dcd6250c331470f9a9693d54523c0581bfe521d 100644 (file)
@@ -907,7 +907,6 @@ _dir_filter()
     -e "s#$SCRATCH_MNT#SCRATCH_MNT#g"       \
     -e "s#$dump_sdir#DUMP_SUBDIR#g"   \
     -e "s#$restore_sdir#RESTORE_SUBDIR#g" \
-    -e "s#$$#PID#g" \
     -e "/Only in SCRATCH_MNT: .use_space/d" \
     -e "s#$RESULT_DIR/##g" \