xfs_healer: fix Makefile errors

Codex had a couple of complaints about the makefile -- mostly that it
never cleans up after xfs_healer_start; and that it should use LTINSTALL
to install libtool binaries.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>

diff --git a/healer/Makefile b/healer/Makefile
index 1db2872617241b01586add329535a7307b76b27a..49a48b52782e722bccdc8a3f3bf41fd00faba211 100644 (file)
--- a/healer/Makefile
+++ b/healer/Makefile
@@ -42,9 +42,12 @@ endif # HAVE_SYSTEMD
 
 ifeq ($(HAVE_HEALER_START_DEPS),yes)
 BUILD_TARGETS += xfs_healer_start
+LDIRT += xfs_healer_start xfs_healer_start.o
 SYSTEMD_SERVICES += xfs_healer_start.service
 endif # xfs_healer_start deps
 
+LDIRT += $(SYSTEMD_SERVICES)
+
 default: depend $(BUILD_TARGETS) $(SYSTEMD_SERVICES)
 
 xfs_healer_start: $(SUBDIRS) xfs_healer_start.o $(LTDEPENDENCIES)
@@ -62,7 +65,7 @@ install: $(INSTALL_HEALER)
 
 install-healer: default
        $(INSTALL) -m 755 -d $(PKG_LIBEXEC_DIR)
-       $(INSTALL) -m 755 $(BUILD_TARGETS) $(PKG_LIBEXEC_DIR)
+       $(LTINSTALL) -m 755 $(BUILD_TARGETS) $(PKG_LIBEXEC_DIR)
 
 install-systemd: default
        $(INSTALL) -m 755 -d $(SYSTEMD_SYSTEM_UNIT_DIR)