]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
shared/272: don't try to use O_DIRECT
authorTheodore Ts'o <tytso@mit.edu>
Thu, 9 Jun 2016 18:42:31 +0000 (14:42 -0400)
committerEryu Guan <eguan@redhat.com>
Wed, 15 Jun 2016 07:37:26 +0000 (15:37 +0800)
A comment in shared/272 claims that ext4 supports O_DIRECT in
data=journalling mode.  Actually, it doesn't, it was just silently
ignoring O_DIRECT, let's not try to test O_DIRECT for either ext3 or
ext4 in this test.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
tests/shared/272

index e5adf385bb52a9067eaf123dbc13754b14f5ec01..7023b65749cdfd97a8f0efbdb2cb2b8d3a51399e 100755 (executable)
@@ -31,10 +31,8 @@ tmp=/tmp/$$
 status=1       # failure is the default!
 trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
 
-# ext3 doesn't support direct IO in journalling mode
+# ext3 and ext4 don't support direct IO in journalling mode
 write_opt_list="iflag=noatime conv=notrunc conv=fsync"
-# For filesystems that can handle it, add also direct IO test
-[ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct"
 
 # get standard environment, filters and checks
 . ./common/rc