fs/ceph: add a bunch of missing ceph_path_info initializers

ceph_mdsc_build_path() must be called with a zero-initialized
ceph_path_info parameter, or else the following
ceph_mdsc_free_path_info() may crash.

Example crash (on Linux 6.18.12):

  virt_to_cache: Object is not a Slab page!
  WARNING: CPU: 184 PID: 2871736 at mm/slub.c:6732 kmem_cache_free+0x316/0x400
  [...]
  Call Trace:
   [...]
   ceph_open+0x13d/0x3e0
   do_dentry_open+0x134/0x480
   vfs_open+0x2a/0xe0
   path_openat+0x9a3/0x1160
  [...]
  cache_from_obj: Wrong slab cache. names_cache but object is from ceph_inode_info
  WARNING: CPU: 184 PID: 2871736 at mm/slub.c:6746 kmem_cache_free+0x2dd/0x400
  [...]
  kernel BUG at mm/slub.c:634!
  Oops: invalid opcode: 0000 [#1] SMP NOPTI
  RIP: 0010:__slab_free+0x1a4/0x350

Some of the ceph_mdsc_build_path() callers had initializers, but
others had not, even though they were all added by
commit 15f519e9f883 ("ceph: fix race condition validating r_parent
before applying state").
The ones without initializer are suspectible to random
crashes.  (I can imagine it could even be possible to exploit this bug
to elevate privileges.)

Unfortunately, these Ceph functions are undocumented and its semantics
can only be derived from the code.  I see that ceph_mdsc_build_path()
initializes the structure only on success, but not on error.

Calling ceph_mdsc_free_path_info() after a failed
ceph_mdsc_build_path() call does not even make sense, but that's what
all callers do, and for it to be safe, the structure must be
zero-initialized.  The least intrusive approach to fix this is
therefore to add initializers everywhere.

Fixes: 15f519e9f883 ("ceph: fix race condition validating r_parent before applying state")
Cc: stable@vger.kernel.org
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>

diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
index 6a7f418aa9e5cd4931a08d7e8995530b25619768..e54020eded1be2ca902801df15121ca465fbff65 100644 (file)
--- a/fs/ceph/debugfs.c
+++ b/fs/ceph/debugfs.c
@@ -86,7 +86,7 @@ static int mdsc_show(struct seq_file *s, void *p)
                if (req->r_inode) {
                        seq_printf(s, " #%llx", ceph_ino(req->r_inode));
                } else if (req->r_dentry) {
-                       struct ceph_path_info path_info;
+                       struct ceph_path_info path_info = {0};
                        path = ceph_mdsc_build_path(mdsc, req->r_dentry, &path_info, 0);
                        if (IS_ERR(path))
                                path = NULL;
@@ -105,7 +105,7 @@ static int mdsc_show(struct seq_file *s, void *p)
                }
 
                if (req->r_old_dentry) {
-                       struct ceph_path_info path_info;
+                       struct ceph_path_info path_info = {0};
                        path = ceph_mdsc_build_path(mdsc, req->r_old_dentry, &path_info, 0);
                        if (IS_ERR(path))
                                path = NULL;

diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
index 804588524cd570078ba59bf38d2460950ca67daf..d26585c471ad7b2cdf43bc0055687ecb532d6dd1 100644 (file)
--- a/fs/ceph/dir.c
+++ b/fs/ceph/dir.c
@@ -1363,7 +1363,7 @@ static int ceph_unlink(struct inode *dir, struct dentry *dentry)
        if (!dn) {
                try_async = false;
        } else {
-               struct ceph_path_info path_info;
+               struct ceph_path_info path_info = {0};
                path = ceph_mdsc_build_path(mdsc, dn, &path_info, 0);
                if (IS_ERR(path)) {
                        try_async = false;

diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index a8fa2404bf1849436cb05e32c53239d64fd64ce9..b3129c73bc6560bd0242e6a80fe9d9ffbc5cc822 100644 (file)
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -397,7 +397,7 @@ int ceph_open(struct inode *inode, struct file *file)
        if (!dentry) {
                do_sync = true;
        } else {
-               struct ceph_path_info path_info;
+               struct ceph_path_info path_info = {0};
                path = ceph_mdsc_build_path(mdsc, dentry, &path_info, 0);
                if (IS_ERR(path)) {
                        do_sync = true;
@@ -807,7 +807,7 @@ int ceph_atomic_open(struct inode *dir, struct dentry *dentry,
        if (!dn) {
                try_async = false;
        } else {
-               struct ceph_path_info path_info;
+               struct ceph_path_info path_info = {0};
                path = ceph_mdsc_build_path(mdsc, dn, &path_info, 0);
                if (IS_ERR(path)) {
                        try_async = false;

diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index e67ab9740311a2389d0a2eae1262cff47fb72480..0fa38236a2915cec603ec288b6e5b085821ef1d6 100644 (file)
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -2568,7 +2568,7 @@ int __ceph_setattr(struct mnt_idmap *idmap, struct inode *inode,
        if (!dentry) {
                do_sync = true;
        } else {
-               struct ceph_path_info path_info;
+               struct ceph_path_info path_info = {0};
                path = ceph_mdsc_build_path(mdsc, dentry, &path_info, 0);
                if (IS_ERR(path)) {
                        do_sync = true;