]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
mmc: sdhci-brcmstb: use correct register offset for V1 pin_sel restore
authorKamal Dasu <kamal.dasu@broadcom.com>
Mon, 16 Feb 2026 19:15:43 +0000 (14:15 -0500)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 23 Feb 2026 11:05:20 +0000 (12:05 +0100)
The restore path for SDIO_CFG_CORE_V1 was incorrectly using
SDIO_CFG_SD_PIN_SEL (offset 0x44) instead of SDIO_CFG_V1_SD_PIN_SEL
(offset 0x54), causing the wrong register to be written on resume.
The save path already uses the correct V1-specific offset. This
affects BCM7445 and BCM72116 platforms which use the V1 config core.

Fixes: b7e614802e3f ("mmc: sdhci-brcmstb: save and restore registers during PM")
Signed-off-by: Kamal Dasu <kamal.dasu@broadcom.com>
Cc: stable@vger.kernel.org
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-brcmstb.c

index c9442499876c32c6031a144c8e6938defddc4cba..57e45951644e308221336e8aa8f42639168139d7 100644 (file)
@@ -116,7 +116,7 @@ static void sdhci_brcmstb_restore_regs(struct mmc_host *mmc, enum cfg_core_ver v
                writel(sr->boot_main_ctl, priv->boot_regs + SDIO_BOOT_MAIN_CTL);
 
        if (ver == SDIO_CFG_CORE_V1) {
-               writel(sr->sd_pin_sel, cr + SDIO_CFG_SD_PIN_SEL);
+               writel(sr->sd_pin_sel, cr + SDIO_CFG_V1_SD_PIN_SEL);
                return;
        }