]> git.apps.os.sepia.ceph.com Git - xfsprogs-dev.git/commitdiff
xfs: don't return XFS_ATTR_PARENT attributes via listxattr
authorAllison Henderson <allison.henderson@oracle.com>
Mon, 29 Jul 2024 23:22:48 +0000 (16:22 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Tue, 30 Jul 2024 00:01:03 +0000 (17:01 -0700)
Source kernel commit: daf9f884906bcfcffe26967aee9ece893fba019b

Parent pointers are internal filesystem metadata.  They're not intended
to be directly visible to userspace, so filter them out of
xfs_xattr_put_listent so that they don't appear in listxattr.

Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Inspired-by: Andrey Albershteyn <aalbersh@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
[djwong: change this to XFS_ATTR_PRIVATE_NSP_MASK per fsverity patchset]
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
libxfs/xfs_da_format.h

index 1395ad1937c5357b6e9133e4b659f5a5780c0872..ebde6eb1da65d4a7cd500157c377e56025280ed6 100644 (file)
@@ -726,6 +726,9 @@ struct xfs_attr3_leafblock {
                                         XFS_ATTR_SECURE | \
                                         XFS_ATTR_PARENT)
 
+/* Private attr namespaces not exposed to userspace */
+#define XFS_ATTR_PRIVATE_NSP_MASK      (XFS_ATTR_PARENT)
+
 #define XFS_ATTR_ONDISK_MASK   (XFS_ATTR_NSP_ONDISK_MASK | \
                                 XFS_ATTR_LOCAL | \
                                 XFS_ATTR_INCOMPLETE)