]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
Merge PR #39682 into master
authorPatrick Donnelly <pdonnell@redhat.com>
Wed, 3 Mar 2021 18:05:35 +0000 (10:05 -0800)
committerPatrick Donnelly <pdonnell@redhat.com>
Wed, 3 Mar 2021 18:05:35 +0000 (10:05 -0800)
* refs/pull/39682/head:
vstart_runner: remove duplicate methods from LocalCephManager

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
1  2 
qa/tasks/vstart_runner.py

index f717030b941df38e0335f614683c2260e084abb5,c07dbb4e8f5ea60b0b83da9a4d2d0d9e9832aa97..6ee66214d2bc9ae1a22e1bef7b96dbb446ba4fd8
@@@ -1007,57 -1009,11 +1007,10 @@@ class LocalCephManager(CephManager)
          if stdout is None:
              stdout = StringIO()
  
 -        return self.controller.run(
 -            args=[os.path.join(BIN_PREFIX, "ceph"), "daemon",
 -                  "{0}.{1}".format(daemon_type, daemon_id)] + command,
 -            check_status=check_status, timeout=timeout, stdout=stdout)
 +        args=[CEPH_CMD, "daemon", f'{daemon_type}', f'{daemon_id}'] + command
 +        return self.controller.run(args=args, check_status=check_status,
 +                                   timeout=timeout, stdout=stdout)
  
-     def get_mon_socks(self):
-         """
-         Get monitor sockets.
-         :return socks: tuple of strings; strings are individual sockets.
-         """
-         from json import loads
-         output = loads(self.raw_cluster_cmd('--format=json', 'mon', 'dump'))
-         socks = []
-         for mon in output['mons']:
-             for addrvec_mem in mon['public_addrs']['addrvec']:
-                 socks.append(addrvec_mem['addr'])
-         return tuple(socks)
-     def get_msgrv1_mon_socks(self):
-         """
-         Get monitor sockets that use msgrv2 to operate.
-         :return socks: tuple of strings; strings are individual sockets.
-         """
-         from json import loads
-         output = loads(self.raw_cluster_cmd('--format=json', 'mon', 'dump'))
-         socks = []
-         for mon in output['mons']:
-             for addrvec_mem in mon['public_addrs']['addrvec']:
-                 if addrvec_mem['type'] == 'v1':
-                     socks.append(addrvec_mem['addr'])
-         return tuple(socks)
-     def get_msgrv2_mon_socks(self):
-         """
-         Get monitor sockets that use msgrv2 to operate.
-         :return socks: tuple of strings; strings are individual sockets.
-         """
-         from json import loads
-         output = loads(self.raw_cluster_cmd('--format=json', 'mon', 'dump'))
-         socks = []
-         for mon in output['mons']:
-             for addrvec_mem in mon['public_addrs']['addrvec']:
-                 if addrvec_mem['type'] == 'v2':
-                     socks.append(addrvec_mem['addr'])
-         return tuple(socks)
  
  class LocalCephCluster(CephCluster):
      def __init__(self, ctx):