]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Bypass unused parameterization in ExternalSSTFileBasicTest.IngestExte… (#8910)
authorPeter Dillinger <peterd@fb.com>
Mon, 13 Sep 2021 19:16:51 +0000 (12:16 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 13 Sep 2021 19:18:15 +0000 (12:18 -0700)
Summary:
Facebook infrastructure doesn't like continuously skipping
tests, so fixing this permanently disabled parameterization to BYPASS
instead of SKIP. (Internal ref: T100525285)

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8910

Test Plan: manual

Reviewed By: anand1976

Differential Revision: D30905169

Pulled By: pdillinger

fbshipit-source-id: e23d63d2aa800e54676269fad3a093cd3f9f222d

db/external_sst_file_basic_test.cc

index 71c2f7bce0ffc83efb067aa30ba6285ea62347f5..a006a817da12e37e71d3ce20249044de5ab12d53 100644 (file)
@@ -1524,7 +1524,11 @@ TEST_P(ExternalSSTFileBasicTest, IngestFileWithFirstByteTampered) {
 
 TEST_P(ExternalSSTFileBasicTest, IngestExternalFileWithCorruptedPropsBlock) {
   bool verify_checksums_before_ingest = std::get<1>(GetParam());
-  if (!verify_checksums_before_ingest || !random_rwfile_supported_) {
+  if (!verify_checksums_before_ingest) {
+    ROCKSDB_GTEST_BYPASS("Bypassing test when !verify_checksums_before_ingest");
+    return;
+  }
+  if (!random_rwfile_supported_) {
     ROCKSDB_GTEST_SKIP("Test requires NewRandomRWFile support");
     return;
   }