common/options: make runtime vs not runtime explicit, not type-dependent

For built-in types, we have a kludge that non-string types all appear to
be runtime-updateable.  There's no such distinction for module options.

Signed-off-by: Sage Weil <sage@redhat.com>

diff --git a/src/common/options.h b/src/common/options.h
index 7c58856a50f6d18852bc58665d9d2ace95890164..60b5fd7ac35fd6a63a98aca90390c0d833b0200a 100644 (file)
--- a/src/common/options.h
+++ b/src/common/options.h
@@ -376,9 +376,10 @@ struct Option {
   {
     return
       (has_flag(FLAG_RUNTIME)
-       || type == TYPE_BOOL || type == TYPE_INT
-       || type == TYPE_UINT || type == TYPE_FLOAT
-       || type == TYPE_SIZE || type == TYPE_SECS)
+       || (!has_flag(FLAG_MGR)
+          && (type == TYPE_BOOL || type == TYPE_INT
+              || type == TYPE_UINT || type == TYPE_FLOAT
+              || type == TYPE_SIZE || type == TYPE_SECS)))
       && !has_flag(FLAG_STARTUP)
       && !has_flag(FLAG_CLUSTER_CREATE)
       && !has_flag(FLAG_CREATE);