]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
osd/PG: do not assume delete event means found_missing
authorSage Weil <sage@redhat.com>
Tue, 26 Jun 2018 02:08:48 +0000 (21:08 -0500)
committerSage Weil <sage@redhat.com>
Tue, 26 Jun 2018 02:08:48 +0000 (21:08 -0500)
This condition was introduced in 3a9d056d843bcafd26d78950b84e2844f8a3a9a1
as part of the missing deletes series, without a clear motivation.  The
best guess is that it was either compensating for some other unfound bug
or simply being a bit overaggressive.

The problem is that it triggers a notify being sent to the sender, or
restarts recovery, both of which are overreactions.

Signed-off-by: Sage Weil <sage@redhat.com>
src/osd/PG.cc

index 70b7184ad65ac7a2480a9330b0b7b3cfafd9ab9d..8b51745dd4259b2ec10f582ca8bbcb6563546d21 100644 (file)
@@ -665,7 +665,6 @@ bool PG::MissingLoc::add_source_info(
     if (p->second.is_delete()) {
       ldout(pg->cct, 10) << __func__ << " " << soid
                         << " delete, ignoring source" << dendl;
-      found_missing = true;
       continue;
     }
     if (oinfo.last_update < need) {