]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
os/bluestore/BlueFS: check flush result
authorSage Weil <sage@redhat.com>
Mon, 28 Nov 2016 18:45:35 +0000 (13:45 -0500)
committerSage Weil <sage@redhat.com>
Mon, 28 Nov 2016 19:29:11 +0000 (14:29 -0500)
CID 1394759 (#1 of 1): Unchecked return value (CHECKED_RETURN)
20. check_return: Calling _flush without checking return value (as is done elsewhere 4 out of 5 times).

Signed-off-by: Sage Weil <sage@redhat.com>
src/os/bluestore/BlueFS.cc

index 9d32697343f2ef212620d5566f09f55fa56176ef..8df7e712903c7ff858d484c817346f7ee5a8de89 100644 (file)
@@ -1178,7 +1178,8 @@ void BlueFS::_compact_log_async(std::unique_lock<std::mutex>& l)
   new_log_writer->append(bl);
 
   // 3. flush
-  _flush(new_log_writer, true);
+  r = _flush(new_log_writer, true);
+  assert(r == 0);
   lock.unlock();
 
   // 4. wait