]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
Revert to v2.1.6 (631e6d0fbbb2ddc640a1c57dccb4d998099b5d7b) 1280/head
authorAndrew Schoen <aschoen@redhat.com>
Fri, 3 Feb 2017 18:04:02 +0000 (12:04 -0600)
committerAndrew Schoen <aschoen@redhat.com>
Fri, 3 Feb 2017 18:07:55 +0000 (12:07 -0600)
15 files changed:
README.md
group_vars/all.yml.sample
roles/ceph-common/defaults/main.yml
roles/ceph-common/handlers/validate-osd.yml
roles/ceph-docker-common/tasks/main.yml [deleted file]
roles/ceph-docker-common/tasks/system_checks.yml [deleted file]
roles/ceph-mds/tasks/docker/start_docker_mds.yml
roles/ceph-mon/tasks/docker/main.yml
roles/ceph-mon/tasks/docker/start_docker_monitor.yml
roles/ceph-mon/templates/ceph-mon.service.j2
roles/ceph-nfs/tasks/docker/start_docker_nfs.yml
roles/ceph-osd/tasks/docker/start_docker_osd.yml
roles/ceph-rbd-mirror/tasks/docker/start_docker_rbd_mirror.yml
roles/ceph-rgw/tasks/docker/start_docker_rgw.yml
roles/ceph-rgw/tasks/multisite/main.yml

index 8a9c4af1a0d891426b86be419def93fcf39bb64d..a2d8be69bf5edb2ce747c586c0a34e41f363300a 100644 (file)
--- a/README.md
+++ b/README.md
@@ -48,10 +48,7 @@ ceph_conf_overrides:
      osd mkfs type: ext4
 ```
 
-### Note
-* It is not recommended to use underscores when defining options in the `ceph_conf_overrides` variable (ex. osd_mkfs_type) as this may cause issues with
-incorrect configuration options appearing in ceph.conf.
-* We will no longer accept pull requests that modify the ceph.conf template unless it helps the deployment. For simple configuration tweaks
+**Note:** we will no longer accept pull requests that modify the ceph.conf template unless it helps the deployment. For simple configuration tweaks
 please use the `ceph_conf_overrides` variable.
 
 ## Special notes
index e6fccbb3b4d9e847b9d6ddf4d168efa733fba6c9..9eb23f1cf7b19153f421f203e3e0993c1c0bd923 100644 (file)
@@ -330,7 +330,6 @@ dummy:
 #handler_health_mon_check_delay: 10
 #handler_health_osd_check_retries: 40
 #handler_health_osd_check_delay: 30
-#handler_health_osd_check: true
 
 ###################
 # CONFIG OVERRIDE #
index f20fd3a6cff672069c47176e842fe1ad4be20b78..50bd4b3ddd04057ae0395183612bbddcafc52efd 100644 (file)
@@ -322,7 +322,6 @@ handler_health_mon_check_retries: 5
 handler_health_mon_check_delay: 10
 handler_health_osd_check_retries: 40
 handler_health_osd_check_delay: 30
-handler_health_osd_check: true
 
 ###################
 # CONFIG OVERRIDE #
index 99d1c2f871d09e5100ed5795ce8fc6abf5c7f4a8..b83d0952d0d255a0bf77c4465e5ffaf55d3b9525 100644 (file)
@@ -17,4 +17,3 @@
   retries: "{{ handler_health_osd_check_retries }}"
   delay: "{{ handler_health_osd_check_delay }}"
   delegate_to: "{{ groups[mon_group_name][0] }}"
-  when: handler_health_osd_check
diff --git a/roles/ceph-docker-common/tasks/main.yml b/roles/ceph-docker-common/tasks/main.yml
deleted file mode 100644 (file)
index 14e987c..0000000
+++ /dev/null
@@ -1,2 +0,0 @@
----
-- include: system_checks.yml
diff --git a/roles/ceph-docker-common/tasks/system_checks.yml b/roles/ceph-docker-common/tasks/system_checks.yml
deleted file mode 100644 (file)
index a9a5311..0000000
+++ /dev/null
@@ -1,5 +0,0 @@
----
-- name: fail if systemd is not present
-  fail:
-    msg: "Systemd must be present"
-  when: ansible_service_mgr != 'systemd'
index d49e56e67c97dca61e3a2df982e209a8882f4fd0..cb76e977758c3ee621da5337f397094f9acaf68e 100644 (file)
@@ -8,22 +8,26 @@
     owner: "root"
     group: "root"
     mode: "0644"
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: link systemd unit file for mds instance
   file:
     src: /var/lib/ceph/ceph-mds@.service
     dest: /etc/systemd/system/multi-user.target.wants/ceph-mds@{{ ansible_hostname }}.service
     state: link
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: enable systemd unit file for mds instance
   command: systemctl enable /etc/systemd/system/multi-user.target.wants/ceph-mds@{{ ansible_hostname }}.service
   failed_when: false
   changed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: reload systemd unit files
   command: systemctl daemon-reload
   changed_when: false
   failed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: systemd start mds container
   service:
index 15499e6e201c381f33c43b225a6d650222686489..62d11175095c121d05be070a753eab98cbaa842b 100644 (file)
 
 - include: start_docker_monitor.yml
 
-- name: wait for monitor socket to exist
-  command: docker exec {{ ansible_hostname }} stat /var/run/ceph/{{ cluster }}-mon.{{ ansible_hostname }}.asok
-  register: monitor_socket
-  retries: 5
-  delay: 10
-  until: monitor_socket.rc == 0
-
-- name: force peer addition as potential bootstrap peer for cluster bringup
-  command: docker exec {{ ansible_hostname }} ceph --admin-daemon /var/run/ceph/{{ cluster }}-mon.{{ ansible_hostname }}.asok add_bootstrap_peer_hint {{ hostvars[item]['ansible_' + ceph_mon_docker_interface].ipv4.address }}
-  with_items: "{{ groups.mons }}"
-  changed_when: false
-  failed_when: false
-  when:
-    - inventory_hostname == groups.mons[0]
-    - not mon_containerized_deployment_with_kv
+# NOTE: if we don't wait we will attempt to copy config to ansible host
+# before admin key is ready, preventing future daemons e.g. ceph-mds from
+# properly retrieving key
+- name: "wait for {{ cluster }}.client.admin.keyring exists"
+  wait_for:
+    path: /etc/ceph/{{ cluster }}.client.admin.keyring
+  when: cephx
 
 - include: copy_configs.yml
   when: not mon_containerized_deployment_with_kv
 
 - name: create ceph rest api keyring when mon is containerized
-  command: docker exec {{ ansible_hostname }} ceph --cluster {{ cluster }} auth get-or-create client.restapi osd 'allow *' mon 'allow *' -o /etc/ceph/{{ cluster }}.client.restapi.keyring
+  command: docker exec {{ ansible_hostname }} ceph auth get-or-create client.restapi osd 'allow *' mon 'allow *' -o /etc/ceph/ceph.client.restapi.keyring
   args:
-     creates: /etc/ceph/{{ cluster }}.client.restapi.keyring
+     creates: /etc/ceph/ceph.client.restapi.keyring
   changed_when: false
   when:
     - cephx
index 50dc8f37d6e6c112ff74c16010c73a7b0abae562..a2071936c17db81a2e0ed86e33b7d1f8b90fb334 100644 (file)
@@ -40,6 +40,7 @@
     image: "{{ ceph_mon_docker_username }}/{{ ceph_mon_docker_imagename }}:{{ ceph_mon_docker_image_tag }}"
   when: mon_containerized_deployment_with_kv
 
+# Use systemd to manage container on Atomic host and CoreOS
 - name: generate systemd unit file
   become: true
   template:
     owner: "root"
     group: "root"
     mode: "0644"
+  when:  ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: enable systemd unit file for mon instance
   shell: systemctl enable ceph-mon@{{ ansible_hostname }}.service
   failed_when: false
   changed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: reload systemd unit files
   shell: systemctl daemon-reload
   changed_when: false
   failed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: systemd start mon container
   service:
index 1815015c5bf675373cb38324019b85e695058b40..a9f41a92319a04ff5dd041ee27c731a6932e71f7 100644 (file)
@@ -5,7 +5,7 @@ After=docker.service
 [Service]
 EnvironmentFile=-/etc/environment
 ExecStartPre=-/usr/bin/docker rm %i
-ExecStartPre=$(command -v mkdir) -p /etc/ceph /var/lib/ceph/mon
+ExecStartPre=/usr/bin/mkdir -p /etc/ceph /var/lib/ceph/mon
 ExecStart=/usr/bin/docker run --rm --name %i --net=host \
    {% if not mon_containerized_deployment_with_kv -%}
    -v /var/lib/ceph:/var/lib/ceph \
index b4685a6b73711ae6516a32cc93cf3a62c1a41570..3b297d544e378220f35b52ee9886856d943f26fa 100644 (file)
@@ -8,22 +8,34 @@
     owner: "root"
     group: "root"
     mode: "0644"
+  when:
+    is_atomic or
+    ansible_os_family == 'CoreOS'
 
 - name: link systemd unit file for NFS instance
   file:
     src: /var/lib/nfs/ganesha/ceph-nfs@.service
     dest: /etc/systemd/system/multi-user.target.wants/ceph-nfs@{{ ansible_hostname }}.service
     state: link
+  when:
+    is_atomic or
+    ansible_os_family == 'CoreOS'
 
 - name: enable systemd unit file for NFS instance
   shell: systemctl enable /etc/systemd/system/multi-user.target.wants/ceph-nfs@{{ ansible_hostname }}.service
   failed_when: false
   changed_when: false
+  when:
+    is_atomic or
+    ansible_os_family == 'CoreOS'
 
 - name: reload systemd unit files
   shell: systemctl daemon-reload
   changed_when: false
   failed_when: false
+  when:
+    is_atomic or
+    ansible_os_family == 'CoreOS'
 
 - name: systemd start NFS container
   service:
index 196725b3179a209887e14ea9dd93932fb5c6451f..5c830804f5de0443abded80f757ec32ddf995c67 100644 (file)
@@ -67,6 +67,7 @@
     - ceph_osd_docker_prepare_env is defined
     - osd_containerized_deployment_with_kv
 
+# Use systemd to manage container on appropriate host
 - name: generate systemd unit file
   become: true
   template:
     group: "root"
     mode: "0644"
   failed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: enable systemd unit file for osd instance
   shell: systemctl enable ceph-osd@{{ item | basename }}.service
   failed_when: false
   changed_when: false
   with_items: "{{ ceph_osd_docker_devices }}"
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: reload systemd unit files
   shell: systemctl daemon-reload
   changed_when: false
   failed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: systemd start osd container
   service:
index afaffafe228f0becc443ce88e8948be52c0c74df..b3d127ce3a248d6812bf155360a5a34cc7789cf1 100644 (file)
@@ -8,16 +8,19 @@
     owner: "root"
     group: "root"
     mode: "0644"
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: enable systemd unit file for rbd mirror instance
   command: systemctl enable ceph-rbd-mirror@{{ ansible_hostname }}.service
   failed_when: false
   changed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: reload systemd unit files
   command: systemctl daemon-reload
   changed_when: false
   failed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: systemd start rbd mirror container
   service:
index d86a062c903391e7bdac90cd79ba8be656cbd9f6..072615eca7d33f72e634342d7eb6e7e2fe94121c 100644 (file)
@@ -8,22 +8,26 @@
     owner: "root"
     group: "root"
     mode: "0644"
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: link systemd unit file for rgw instance
   file:
     src: /var/lib/ceph/ceph-rgw@.service
     dest: /etc/systemd/system/multi-user.target.wants/ceph-rgw@{{ ansible_hostname }}.service
     state: link
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: enable systemd unit file for rgw instance
   shell: systemctl enable /etc/systemd/system/multi-user.target.wants/ceph-rgw@{{ ansible_hostname }}.service
   failed_when: false
   changed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: reload systemd unit files
   shell: systemctl daemon-reload
   changed_when: false
   failed_when: false
+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'CoreOS'
 
 - name: systemd start rgw container
   service:
index 2f7114a3dacd2a4cadb4db78d89fdabc115fbc9d..0dc6d94da096a83e39b79d3092f2c4dae2430354 100644 (file)
 
 # Continue with common tasks
 - name: add zone to rgw stanza in ceph.conf
-  ini_file:
+  lineinfile:
     dest: "/etc/ceph/{{ cluster }}.conf"
-    section: "client.rgw.{{ ansible_hostname }}"
-    option: "rgw_zone"
-    value: "{{ rgw_zone }}"
+    regexp: "{{ ansible_host }}"
+    insertafter: "^[client.rgw.{{ ansible_host }}]"
+    line: "rgw_zone = {{ rgw_zone }}"
+    state: present
   notify:
     - restart rgw