mgr/dashboard: Add SSO guard service.

Signed-off-by: Volker Theile <vtheile@suse.com>

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts b/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts
index e38235fcf294bc058cbcf8856ecc7ee0695ac767..6445054f7d49cef871fe8a62d95c51ac3ea2778f 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts
@@ -31,6 +31,7 @@ import { BreadcrumbsResolver, IBreadcrumb } from './shared/models/breadcrumbs';
 import { AuthGuardService } from './shared/services/auth-guard.service';
 import { FeatureTogglesGuardService } from './shared/services/feature-toggles-guard.service';
 import { ModuleStatusGuardService } from './shared/services/module-status-guard.service';
+import { NoSsoGuardService } from './shared/services/no-sso-guard.service';
 
 export class PerformanceCounterBreadcrumbsResolver extends BreadcrumbsResolver {
   resolve(route: ActivatedRouteSnapshot) {
@@ -228,6 +229,7 @@ const routes: Routes = [
       {
         path: URLVerbs.EDIT,
         component: UserPasswordFormComponent,
+        canActivate: [NoSsoGuardService],
         data: { breadcrumbs: ActionLabels.EDIT }
       }
     ]

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/no-sso-guard.service.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/no-sso-guard.service.spec.ts
new file mode 100644 (file)
index 0000000..76bbd4f
--- /dev/null
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/no-sso-guard.service.spec.ts
@@ -0,0 +1,51 @@
+import { Component, NgZone } from '@angular/core';
+import { fakeAsync, TestBed, tick } from '@angular/core/testing';
+import { Router, Routes } from '@angular/router';
+import { RouterTestingModule } from '@angular/router/testing';
+
+import { configureTestBed } from '../../../testing/unit-test-helper';
+import { AuthStorageService } from './auth-storage.service';
+import { NoSsoGuardService } from './no-sso-guard.service';
+
+describe('NoSsoGuardService', () => {
+  let service: NoSsoGuardService;
+  let authStorageService: AuthStorageService;
+  let ngZone: NgZone;
+  let router: Router;
+
+  @Component({ selector: 'cd-404', template: '' })
+  class NotFoundComponent {}
+
+  const routes: Routes = [{ path: '404', component: NotFoundComponent }];
+
+  configureTestBed({
+    imports: [RouterTestingModule.withRoutes(routes)],
+    providers: [NoSsoGuardService, AuthStorageService],
+    declarations: [NotFoundComponent]
+  });
+
+  beforeEach(() => {
+    service = TestBed.get(NoSsoGuardService);
+    authStorageService = TestBed.get(AuthStorageService);
+    ngZone = TestBed.get(NgZone);
+    router = TestBed.get(Router);
+  });
+
+  it('should be created', () => {
+    expect(service).toBeTruthy();
+  });
+
+  it('should allow if not logged in via SSO', () => {
+    spyOn(authStorageService, 'isSSO').and.returnValue(false);
+    expect(service.canActivate()).toBe(true);
+  });
+
+  it('should prevent if logged in via SSO', fakeAsync(() => {
+    spyOn(authStorageService, 'isSSO').and.returnValue(true);
+    ngZone.run(() => {
+      expect(service.canActivate()).toBe(false);
+    });
+    tick();
+    expect(router.url).toBe('/404');
+  }));
+});

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/no-sso-guard.service.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/no-sso-guard.service.ts
new file mode 100644 (file)
index 0000000..79338a8
--- /dev/null
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/no-sso-guard.service.ts
@@ -0,0 +1,27 @@
+import { Injectable } from '@angular/core';
+import { CanActivate, CanActivateChild, Router } from '@angular/router';
+
+import { AuthStorageService } from './auth-storage.service';
+
+/**
+ * This service checks if a route can be activated if the user has not
+ * been logged in via SSO.
+ */
+@Injectable({
+  providedIn: 'root'
+})
+export class NoSsoGuardService implements CanActivate, CanActivateChild {
+  constructor(private authStorageService: AuthStorageService, private router: Router) {}
+
+  canActivate() {
+    if (!this.authStorageService.isSSO()) {
+      return true;
+    }
+    this.router.navigate(['404']);
+    return false;
+  }
+
+  canActivateChild(): boolean {
+    return this.canActivate();
+  }
+}