crimson/os/seastore/root_block: fix copy constructor

Otherwise, we don't appropriately initialize root.

Signed-off-by: Samuel Just <sjust@redhat.com>

diff --git a/src/crimson/os/seastore/cached_extent.h b/src/crimson/os/seastore/cached_extent.h
index 4f40a3ecd286079ad41a2bc9550b7c8c6112d7bc..6a464d3d907f2d1e7192a04b88c0272e642da3b6 100644 (file)
--- a/src/crimson/os/seastore/cached_extent.h
+++ b/src/crimson/os/seastore/cached_extent.h
@@ -305,9 +305,9 @@ protected:
 
 
   friend class Cache;
-  template <typename T, typename... Args>
-  static TCachedExtentRef<T> make_cached_extent_ref(Args&&... args) {
-    return new T(std::forward<Args>(args)...);
+  template <typename T>
+  static TCachedExtentRef<T> make_cached_extent_ref(bufferptr &&ptr) {
+    return new T(std::move(ptr));
   }
 
   void set_paddr(paddr_t offset) { poffset = offset; }

diff --git a/src/crimson/os/seastore/root_block.h b/src/crimson/os/seastore/root_block.h
index 96fc14dfb6d33383d15f389061667a926490a166..4ce8932c24e455577b0f0ced6536bca0e1c2aa56 100644 (file)
--- a/src/crimson/os/seastore/root_block.h
+++ b/src/crimson/os/seastore/root_block.h
@@ -47,6 +47,8 @@ struct RootBlock : CachedExtent {
   template <typename... T>
   RootBlock(T&&... t) : CachedExtent(std::forward<T>(t)...) {}
 
+  RootBlock(const RootBlock &rhs) = default;
+
   CachedExtentRef duplicate_for_write() final {
     return CachedExtentRef(new RootBlock(*this));
   };