]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/rgw: fix user cleanup in s3tests task 61405/head
authorCasey Bodley <cbodley@redhat.com>
Thu, 30 Jan 2025 17:31:35 +0000 (12:31 -0500)
committerCasey Bodley <cbodley@redhat.com>
Tue, 4 Feb 2025 16:21:16 +0000 (11:21 -0500)
the if condition was backwards, preventing non-keystone users from being
removed after the s3tests task runs

Fixes: https://tracker.ceph.com/issues/69741
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 4a0ca73f53ad1ddcc22c17c80f153ddd5128649f)

qa/tasks/s3tests.py

index 69ac3591c846ab36b1f8e727220cde0b9e195505..d7ac2b3dbbfef5dfd7f3657392f73d9bb20d00ff 100644 (file)
@@ -213,7 +213,7 @@ def create_users(ctx, config, s3tests_conf):
         for client in config.keys():
             for user in users.values():
                 # don't need to delete keystone users
-                if not user in keystone_users:
+                if section in keystone_users:
                     continue
                 uid = '{user}.{client}'.format(user=user, client=client)
                 cluster_name, daemon_type, client_id = teuthology.split_role(client)