]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
ext4: allow ext4 to use $SCRATCH_LOGDEV
authorJeff Layton <jlayton@redhat.com>
Fri, 16 Jun 2017 19:36:15 +0000 (15:36 -0400)
committerEryu Guan <eguan@redhat.com>
Tue, 20 Jun 2017 12:29:42 +0000 (20:29 +0800)
The writeback error handling test requires that you put the journal on a
separate device. This allows us to use dmerror to simulate data
writeback failure, without affecting the journal.

xfs already has infrastructure for this (a'la $SCRATCH_LOGDEV), so wire
up the ext4 code so that it can do the same thing when _scratch_mkfs is
called.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
common/rc

index d3ce3acc3308b5a80cc4e0510436e1da90899ffa..ad67ea82a7626cd7077bfd820fd4e06e8c7d9a4c 100644 (file)
--- a/common/rc
+++ b/common/rc
@@ -679,6 +679,9 @@ _scratch_mkfs_ext4()
        local tmp=`mktemp`
        local mkfs_status
 
+       [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ] && \
+           $mkfs_cmd -O journal_dev $MKFS_OPTIONS $SCRATCH_LOGDEV && \
+           mkfs_cmd="$mkfs_cmd -J device=$SCRATCH_LOGDEV"
 
        _scratch_do_mkfs "$mkfs_cmd" "$mkfs_filter" $* 2>$tmp.mkfserr 1>$tmp.mkfsstd
        mkfs_status=$?