]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
crimson/net: do not print non-void* pointer
authorKefu Chai <kchai@redhat.com>
Wed, 9 Sep 2020 02:17:28 +0000 (10:17 +0800)
committerKefu Chai <kchai@redhat.com>
Wed, 9 Sep 2020 04:03:37 +0000 (12:03 +0800)
to address the failure like

fmt/core.h:902:19: error: static assertion failed: formatting of non-void pointers is disallowed
  902 |     static_assert(!sizeof(T), "formatting of non-void pointers is disallowed");
      |                   ^~~~~~~~~~

and i searched around, couldn't find any other
statement printing the address of message, so
i think it's not of much use to print their
addresses in a single place, unless we can cross
check them in different places.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/net/ProtocolV2.cc

index fd9567be9949e542d80723f6fa7d910829ec19d1..750f458bd9dfa361ecaf0d61827db1591b18357c 100644 (file)
@@ -1908,8 +1908,8 @@ seastar::future<> ProtocolV2::read_message(utime_t throttle_stamp)
     // elsewhere.  in that case it doesn't matter if we "got" it or not.
     uint64_t cur_seq = conn.in_seq;
     if (message->get_seq() <= cur_seq) {
-      logger().error("{} got old message {} <= {} {} {}, discarding",
-                     conn, message->get_seq(), cur_seq, message, *message);
+      logger().error("{} got old message {} <= {} {}, discarding",
+                     conn, message->get_seq(), cur_seq, *message);
       if (HAVE_FEATURE(conn.features, RECONNECT_SEQ) &&
           local_conf()->ms_die_on_old_message) {
         ceph_assert(0 == "old msgs despite reconnect_seq feature");