run_tasks: catch malformed task case

If you do something like this:

- foo:
- bar:
- baz

Then catching AttributeError is necessary for giving a somewhat
friendlier error on the 'baz' where we have a string instead
of a dict.

Signed-off-by: John Spray <john.spray@redhat.com>

diff --git a/teuthology/run_tasks.py b/teuthology/run_tasks.py
index 99158ff2cdc3dcbdff04dc6088d8468144a8e88f..ada99d0256795ba545ab8a2364ac729f33c75002 100644 (file)
--- a/teuthology/run_tasks.py
+++ b/teuthology/run_tasks.py
@@ -37,7 +37,7 @@ def run_tasks(tasks, ctx):
         for taskdict in tasks:
             try:
                 ((taskname, config),) = taskdict.iteritems()
-            except ValueError:
+            except (ValueError, AttributeError):
                 raise RuntimeError('Invalid task definition: %s' % taskdict)
             log.info('Running task %s...', taskname)
             manager = run_one_task(taskname, ctx=ctx, config=config)