lint: Don't compare to literal True/False

Use `when: var` rather than `when: var == True`

Signed-off-by: Sébastien Han <seb@redhat.com>

diff --git a/roles/ceph-docker-common/tasks/checks.yml b/roles/ceph-docker-common/tasks/checks.yml
index b892cc6422557c0836c75e0fb8dee5845830d962..8bfa16a8b39ee0f3077888d80a41e8007d984f3d 100644 (file)
--- a/roles/ceph-docker-common/tasks/checks.yml
+++ b/roles/ceph-docker-common/tasks/checks.yml
@@ -10,5 +10,5 @@
     - "{{ statconfig.results }}"
   when:
     - inventory_hostname == groups.get(mon_group_name)
-    - item.1.stat.exists == true
+    - item.1.stat.exists
     - ceph_health.stdout_lines | length == 0

diff --git a/roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml b/roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml
index afd474db524694a8de19e8608c684ff5c48a0d5f..ae3456818b021dd7874d03f1f2c3370987b27df1 100644 (file)
--- a/roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml
+++ b/roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml
@@ -26,7 +26,7 @@
   run_once: True
   with_items: "{{ crt_files_exist.results }}"
   when:
-    - item.stat.exists == false
+    - not item.stat.exists
 
 - name: create pem
   shell: >
@@ -37,7 +37,7 @@
   register: pem
   with_items: "{{ crt_files_exist.results }}"
   when:
-    - item.stat.exists == false
+    - not item.stat.exists
 
 - name: create public key from pem
   shell: >

diff --git a/roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml b/roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml
index 4ccbe70cf9c68b78bf1f12fdaf88660dfbe1ad24..0e1d60dfb67f271620c3b40f988f077d1af26409 100644 (file)
--- a/roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml
+++ b/roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml
@@ -58,7 +58,7 @@
     enabled: no
   when:
     - target.stat.exists
-    - target.stat.islnk == False
+    - not target.stat.islnk
 
 - name: enable the rbd-target-gw service and make sure it is running
   service:

diff --git a/roles/ceph-mds/tasks/containerized.yml b/roles/ceph-mds/tasks/containerized.yml
index 9fc286581c34a1cc0baadf2eff83b425ae6ecc2a..f990013685994fee336d1bff8e98816ba6e1fff8 100644 (file)
--- a/roles/ceph-mds/tasks/containerized.yml
+++ b/roles/ceph-mds/tasks/containerized.yml
@@ -43,7 +43,7 @@
   with_together:
     - "{{ ceph_config_keys }}"
     - "{{ statconfig.results }}"
-  when: item.1.stat.exists == true
+  when: item.1.stat.exists
 
 - name: generate systemd unit file
   become: true

diff --git a/roles/ceph-nfs/tasks/pre_requisite_container.yml b/roles/ceph-nfs/tasks/pre_requisite_container.yml
index 3fffdd3873721a61a27535c45f0607648cf3303b..1f2e02a963834b25db0ee2bde640563d56d03046 100644 (file)
--- a/roles/ceph-nfs/tasks/pre_requisite_container.yml
+++ b/roles/ceph-nfs/tasks/pre_requisite_container.yml
@@ -40,7 +40,7 @@
     - "{{ ceph_config_keys }}"
     - "{{ statconfig.results }}"
   when:
-    - item.1.stat.exists == true
+    - item.1.stat.exists
 
 - name: create dbus service file
   become: true

diff --git a/site.yml.sample b/site.yml.sample
index db93692e627398b7f664b3d8642ed30884b9bf5e..c6822f9e730d75ec967ad7c6fb70ac1e96797daa 100644 (file)
--- a/site.yml.sample
+++ b/site.yml.sample
@@ -38,19 +38,19 @@
       raw: sudo apt-get -y install python-simplejson
       ignore_errors: yes
       when:
-        - systempython2.stat is undefined or systempython2.stat.exists == false
+        - systempython2.stat is undefined or not systempython2.stat.exists
 
     - name: install python2 for fedora
       raw: sudo dnf -y install python creates=/usr/bin/python
       ignore_errors: yes
       when:
-        - systempython2.stat is undefined or systempython2.stat.exists == false
+        - systempython2.stat is undefined or not systempython2.stat.exists
 
     - name: install python2 for opensuse
       raw: sudo zypper -n install python-base creates=/usr/bin/python2.7
       ignore_errors: yes
       when:
-        - systempython2.stat is undefined or systempython2.stat.exists == false
+        - systempython2.stat is undefined or not systempython2.stat.exists
 
     - name: gather facts
       setup: