]> git.apps.os.sepia.ceph.com Git - teuthology.git/commitdiff
Revert "[DNM] upgrade check: upgrade to same version is a noop" 1195/head
authorZack Cerza <zack@cerza.org>
Wed, 25 Jul 2018 22:18:36 +0000 (16:18 -0600)
committerGitHub <noreply@github.com>
Wed, 25 Jul 2018 22:18:36 +0000 (16:18 -0600)
teuthology/task/install/__init__.py

index 9218329db054ffbe3c311ff33b64287d5002b2d1..458b2c2b842a17cf2f8af973e9d6066d8348cc3c 100644 (file)
@@ -339,11 +339,6 @@ def upgrade_remote_to_config(ctx, config):
 
     return result
 
-def _upgrade_is_noop(installed_version, upgrade_version):
-    assert installed_version, "installed_version is empty"
-    assert upgrade_version, "upgrade_version is empty"
-    return LooseVersion(installed_version) == LooseVersion(upgrade_version)
-
 def _upgrade_is_downgrade(installed_version, upgrade_version):
     assert installed_version, "installed_version is empty"
     assert upgrade_version, "upgrade_version is empty"
@@ -377,11 +372,6 @@ def upgrade_common(ctx, config, deploy_style):
             i=installed_version,
             u=upgrade_version
         ))
-       if _upgrade_is_noop(installed_version, upgrade_version):
-            raise RuntimeError(
-                "Upgrade to the same version as is already installed is a "
-                " NOOP. Hint: check the test yaml."
-            )
        if _upgrade_is_downgrade(installed_version, upgrade_version):
             raise RuntimeError(
                 "An attempt to upgrade from a higher version to a lower one "