]> git.apps.os.sepia.ceph.com Git - teuthology.git/commitdiff
teuthology-suite: no default value for suite branch 1268/head
authorKyr Shatskyy <kyrylo.shatskyy@gmail.com>
Wed, 20 Mar 2019 17:09:45 +0000 (18:09 +0100)
committerKyr Shatskyy <kyrylo.shatskyy@gmail.com>
Wed, 20 Mar 2019 17:33:07 +0000 (18:33 +0100)
By default suite branch must be equal to ceph one.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
scripts/suite.py
teuthology/suite/__init__.py

index ceb745355f657122042bd5719e6eba73b56cf9ac..abea69d708c9dafd46a1e8957b60b64e7f2fdc84 100644 (file)
@@ -68,7 +68,6 @@ Standard arguments:
                               [default: qa]
   --suite-branch <suite_branch>
                               Use this suite branch instead of the ceph branch
-                              [default: {default_suite_branch}]
   --suite-dir <suite_dir>     Use this alternative directory as-is when
                               assembling jobs from yaml fragments. This causes
                               <suite_branch> to be ignored for scheduling
@@ -144,7 +143,6 @@ Scheduler arguments:
     default_suite_repo=defaults('--suite-repo',
                             config.get_ceph_qa_suite_git_url()),
     default_ceph_branch=defaults('--ceph-branch', 'master'),
-    default_suite_branch=defaults('--suite-branch', 'master'),
     default_teuthology_branch=defaults('--teuthology-branch', 'master'),
 )
 
index ce1980de3dcdf8937735aaa47e15b721b2d74672..488b104b392e77f35823dd62acd034f73c58566c 100644 (file)
@@ -54,6 +54,8 @@ def process_args(args):
         key = key.lstrip('--').replace('-', '_')
         # Rename the key if necessary
         key = rename_args.get(key) or key
+        if key == 'suite_branch':
+            value = value or override_arg_defaults('--suite-branch', None)
         if key == 'suite' and value is not None:
             value = normalize_suite_name(value)
         if key == 'suite_relpath' and value is None: