]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
bufferlist: cleanup semantical wrong for bufferlist::append
authorYankunLi <lioveni99@gmail.com>
Thu, 1 Dec 2016 06:12:03 +0000 (14:12 +0800)
committerYankunLi <lioveni99@gmail.com>
Thu, 1 Dec 2016 09:11:46 +0000 (17:11 +0800)
this is just semantically wrong. as append_buffer.set_offset() was
called, so append_buffer._off is always 0. in other words,
append_buffer.length() == append_buffer.end(). using append_buffer.
length() is better in here.

Signed-off-by: Yankun Li <lioveni99@gmail.com>
src/common/buffer.cc

index dce326dadce608571faf30aad624018c5b3334ea..fa2f5a20aa9d276b7b7e7beef937ce01855e5c20 100644 (file)
@@ -1791,7 +1791,7 @@ static simple_spinlock_t buffer_debug_lock = SIMPLE_SPINLOCK_INITIALIZER;
         if (gap > len) gap = len;
     //cout << "append first char is " << data[0] << ", last char is " << data[len-1] << std::endl;
         append_buffer.append(data, gap);
-        append(append_buffer, append_buffer.end() - gap, gap); // add segment to the list
+        append(append_buffer, append_buffer.length() - gap, gap);      // add segment to the list
         len -= gap;
         data += gap;
       }