]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
btrfs: convert log messages to error level in btrfs_replay_log()
authorFilipe Manana <fdmanana@suse.com>
Mon, 9 Feb 2026 09:49:49 +0000 (09:49 +0000)
committerDavid Sterba <dsterba@suse.com>
Thu, 26 Feb 2026 14:03:27 +0000 (15:03 +0100)
We are logging messages as warnings but they should really have an error
level instead, as if the respective conditions are met the mount will
fail. So convert them to error level and also log the error code returned
by read_tree_block().

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/disk-io.c

index e6574456a3066f403466531034ebbea2df88e6a8..028ba86bcf736e92a41b356d91ccb0c7feadb06a 100644 (file)
@@ -1994,7 +1994,7 @@ static int btrfs_replay_log(struct btrfs_fs_info *fs_info,
        int level = btrfs_super_log_root_level(disk_super);
 
        if (unlikely(fs_devices->rw_devices == 0)) {
-               btrfs_warn(fs_info, "log replay required on RO media");
+               btrfs_err(fs_info, "log replay required on RO media");
                return -EIO;
        }
 
@@ -2008,9 +2008,9 @@ static int btrfs_replay_log(struct btrfs_fs_info *fs_info,
        check.owner_root = BTRFS_TREE_LOG_OBJECTID;
        log_tree_root->node = read_tree_block(fs_info, bytenr, &check);
        if (IS_ERR(log_tree_root->node)) {
-               btrfs_warn(fs_info, "failed to read log tree");
                ret = PTR_ERR(log_tree_root->node);
                log_tree_root->node = NULL;
+               btrfs_err(fs_info, "failed to read log tree with error: %d", ret);
                btrfs_put_root(log_tree_root);
                return ret;
        }