]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-build.git/commitdiff
build: notcmalloc builds enable WITH_BOOST_VALGRIND 1736/head
authorCasey Bodley <cbodley@redhat.com>
Wed, 3 Feb 2021 14:32:28 +0000 (09:32 -0500)
committerCasey Bodley <cbodley@redhat.com>
Wed, 3 Feb 2021 14:38:27 +0000 (09:38 -0500)
this flag silences a false-positive from valgrind in boost::context:
```
<error>
  <unique>0x0</unique>
  <tid>124</tid>
  <kind>InvalidRead</kind>
  <what>Invalid read of size 8</what>
  <stack>
    <frame>
      <ip>0x52FF7E7</ip>
      <obj>/usr/lib64/libradosgw.so.2.0.0</obj>
      <fn>spawn::detail::continuation_context::resume()</fn>
    </frame>
  </stack>
  <auxwhat>Address 0x57f65728 is in a rw- anonymous segment</auxwhat>
</error>
```

Fixes: https://tracker.ceph.com/issues/48963
Signed-off-by: Casey Bodley <cbodley@redhat.com>
ceph-dev-new-setup/build/build
ceph-dev-setup/build/build
ceph-setup/build/build

index 2828855fd4baf88b53e35ce4b3e6534e68a3ca99..a3040aa9b4f3e2774df3f08f283e86adf3d4bcba 100644 (file)
@@ -70,7 +70,7 @@ case "${FLAVOR}" in
     notcmalloc)
         echo "Detected notcmalloc flavor: will use flag: -DALLOCATOR=libc"
         CEPH_EXTRA_RPMBUILD_ARGS="--without tcmalloc"
-        CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=libc -DWITH_CEPH_DEBUG_MUTEX=ON"
+        CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=libc -DWITH_CEPH_DEBUG_MUTEX=ON -DWITH_BOOST_VALGRIND=ON"
         ;;
     default)
         CEPH_EXTRA_RPMBUILD_ARGS="--with tcmalloc"
index f377a213404199459c1d5e84599561eec2866a61..dd601924db36ee2a8425d3bdc5f1811ee63b0457 100644 (file)
@@ -42,7 +42,7 @@ case "${FLAVOR}" in
     notcmalloc)
         echo "Detected notcmalloc flavor: will use flag: -DALLOCATOR=libc"
         CEPH_EXTRA_RPMBUILD_ARGS="--without tcmalloc"
-        CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=libc -DWITH_CEPH_DEBUG_MUTEX=ON"
+        CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=libc -DWITH_CEPH_DEBUG_MUTEX=ON -DWITH_BOOST_VALGRIND=ON"
         ;;
     default)
         CEPH_EXTRA_RPMBUILD_ARGS="--with tcmalloc"
index 7bca374cba9465ef65adb3f9cfaacb9876e7de01..1e90b0751c6be410922b35b57d077134e0642fa7 100644 (file)
@@ -37,7 +37,7 @@ if [ "${FLAVOR}" == "notcmalloc" ]
 then
     echo "Detected notcmalloc flavor: will use flag: -DALLOCATOR=libc"
     CEPH_EXTRA_RPMBUILD_ARGS="--without tcmalloc"
-    CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=libc"
+    CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=libc -DWITH_BOOST_VALGRIND=ON"
 else
     CEPH_EXTRA_RPMBUILD_ARGS="--with tcmalloc"
     CEPH_EXTRA_CMAKE_ARGS="$CEPH_EXTRA_CMAKE_ARGS -DALLOCATOR=tcmalloc"