]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/dashboard: Code refactor rgw migrate component for using correctly the MIGRATE...
authorAfreen <afreen23.git@gmail.com>
Thu, 25 Jan 2024 11:21:06 +0000 (16:51 +0530)
committerAfreen <afreen23.git@gmail.com>
Thu, 25 Jan 2024 11:50:35 +0000 (17:20 +0530)
fixes https://tracker.ceph.com/issues/64152

this.MIGRATE = $localize`Migrate to Multi-Site`;

Just like other action verbs we should set this.Migrate = "MIGRATE" only.
This will require rephrasing in the following places as well:
1. https://github.com/ceph/ceph/blob/d3256c484136a1b32b79a904861f681a9248ba3c/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-details/rgw-multisite-details.component.ts#L223-L228

2. https://github.com/ceph/ceph/blob/d3256c484136a1b32b79a904861f681a9248ba3c/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts#L180-L18

Signed-off-by: Afreen <afreen23.git@gmail.com>
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts
src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts

index b18c5a0b9d76bb3d6bdccf5d957ab9c99edbed2d..51f72dd7f8977d8b6346a2eaa0e03e37765d5667 100644 (file)
     </div>
     <div class="modal-footer">
       <cd-form-button-panel (submitActionEvent)="submit()"
-                            [submitText]="actionLabels.MIGRATE"
+                            [submitText]="actionLabels.MIGRATE + ' ' + 'to Multi-site'"
                             [form]="multisiteMigrateForm"></cd-form-button-panel>
     </div>
     </form>
index 4c2f53b6af1fa11471db850d83072507cfd26938..1073dee429a5f1962de2fdb007e01b748a670dbe 100644 (file)
@@ -181,7 +181,7 @@ export class RgwMultisiteMigrateComponent implements OnInit {
       () => {
         this.notificationService.show(
           NotificationType.success,
-          $localize`${this.actionLabels.MIGRATE} done successfully`
+          $localize`Migration done successfully`
         );
         this.submitAction.emit();
         this.activeModal.close();
index 0f41e2832204d9a43e1764f020978fd8085d82da..7edce5ff6671d036d8e7a82ce2023b828bb7afae 100644 (file)
@@ -150,7 +150,7 @@ export class ActionLabelsI18n {
 
     this.IMPORT = $localize`Import`;
 
-    this.MIGRATE = $localize`Migrate to Multi-site`;
+    this.MIGRATE = $localize`Migrate`;
 
     /* Destroy an existing item */
     this.DELETE = $localize`Delete`;