crash: Fix loop when no done file is present

Fix a loop which prevents the crash deamon to process further crashes
when a crash path exists with a meta file, but a missing done file.
Print a log warning.

Fixes: https://tracker.ceph.com/issues/73846
Signed-off-by: Raimund Sacherer <rsachere@redhat.com>

diff --git a/src/ceph-crash.in b/src/ceph-crash.in
index 52303c3e8a5ff7e21c9c311f8a83fe1ae3ebeb0d..6f57a151093d2bb87f93ace1b8cf415fc83f023f 100755 (executable)
--- a/src/ceph-crash.in
+++ b/src/ceph-crash.in
@@ -77,7 +77,8 @@ def scrape_path(path):
                 # or the daemon crashed before finishing it
                 time.sleep(1)
                 if not os.path.isfile(donepath):
-                    return
+                    log.warning('no `done` file present. Not processing crash path {}.'.format(crashpath))
+                    continue
             # ok, we can process this one
             rc = post_crash(crashpath)
             if rc == 0: