Summary:
Before this PR, extra deps passed in from cmd line to buckifier will be parsed
and used to populate a dict. Using this dict and printing to TARGETS file will
lead to printing u'', disallowed by build tools. This PR removes the u''.
Test Plan (local dev server):
```
python buckifier/buckify_rocksdb.py '{"fake": {"extra_deps": [":test_dep", "//fake/module:mock1"], "extra_compiler_flags": ["-Os", "-DROCKSDB_LITE"]}}'
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6841
Reviewed By: siying
Differential Revision:
D21538155
Pulled By: riversand963
fbshipit-source-id:
09403668a4aa1a15bad7dac229c2bc8ce8ee1349
+ ["test_util/testutil.cc"],
[":rocksdb_lib", ":rocksdb_test_lib"])
- print("Extra dependencies:\n{0}".format(str(deps_map)))
+ print("Extra dependencies:\n{0}".format(json.dumps(deps_map)))
# test for every test we found in the Makefile
for target_alias, deps in deps_map.items():
for test in sorted(tests):
test_target_name,
match_src[0],
is_parallel,
- deps['extra_deps'],
- deps['extra_compiler_flags'])
+ json.dumps(deps['extra_deps']),
+ json.dumps(deps['extra_compiler_flags']))
if test in _EXPORTED_TEST_LIBS:
test_library = "%s_lib" % test_target_name