]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
test/librbd: create shouldn't be called in DiscardTruncate{AssertExists,}
authorIlya Dryomov <idryomov@gmail.com>
Wed, 6 Mar 2019 14:43:12 +0000 (15:43 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 7 Mar 2019 19:37:03 +0000 (20:37 +0100)
MockTestMemIoCtxImpl is a NiceMock which suppresses all "uninteresting
method call" warnings.  Add explicit Times(0) expectations.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/test/librbd/io/test_mock_ObjectRequest.cc

index 2f9368af7a7446dff9d981b595fa91a90f9baff0..98cd102629bd25a0e5f848b56cc4dde58daa8212 100644 (file)
@@ -942,6 +942,8 @@ TEST_F(TestMockIoObjectRequest, DiscardTruncateAssertExists) {
   expect_assert_exists(mock_image_ctx, 0);
   expect_truncate(mock_image_ctx, 0, 0);
 
+  EXPECT_CALL(get_mock_io_ctx(mock_image_ctx.data_ctx), create(_, _)).Times(0);
+
   C_SaferCond ctx;
   auto req = MockObjectDiscardRequest::create_discard(
     &mock_image_ctx, ictx->get_object_name(0), 0, 0,
@@ -975,6 +977,8 @@ TEST_F(TestMockIoObjectRequest, DiscardTruncate) {
   expect_object_map_update(mock_image_ctx, 0, 1, OBJECT_EXISTS, {}, false, 0);
   expect_truncate(mock_image_ctx, 1, 0);
 
+  EXPECT_CALL(get_mock_io_ctx(mock_image_ctx.data_ctx), create(_, _)).Times(0);
+
   C_SaferCond ctx;
   auto req = MockObjectDiscardRequest::create_discard(
     &mock_image_ctx, ictx->get_object_name(0), 0, 1,