]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commitdiff
pcmcia: Use str_off_on() and str_yes_no() helpers
authorThorsten Blum <thorsten.blum@linux.dev>
Fri, 11 Apr 2025 08:44:29 +0000 (10:44 +0200)
committerDominik Brodowski <linux@dominikbrodowski.net>
Sat, 16 Aug 2025 13:40:31 +0000 (15:40 +0200)
Remove hard-coded strings by using the str_off_on() and str_yes_no()
helper functions.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
drivers/pcmcia/socket_sysfs.c

index c7a906664c3696a0e37120b97c0485d855dbc976..4eadd04850662ce0ce722649e308e0cd1bb5e9d6 100644 (file)
@@ -10,6 +10,7 @@
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/string.h>
+#include <linux/string_choices.h>
 #include <linux/major.h>
 #include <linux/errno.h>
 #include <linux/mm.h>
@@ -98,7 +99,7 @@ static ssize_t pccard_show_card_pm_state(struct device *dev,
                                         char *buf)
 {
        struct pcmcia_socket *s = to_socket(dev);
-       return sysfs_emit(buf, "%s\n", s->state & SOCKET_SUSPEND ? "off" : "on");
+       return sysfs_emit(buf, "%s\n", str_off_on(s->state & SOCKET_SUSPEND));
 }
 
 static ssize_t pccard_store_card_pm_state(struct device *dev,
@@ -177,7 +178,7 @@ static ssize_t pccard_show_resource(struct device *dev,
                                    struct device_attribute *attr, char *buf)
 {
        struct pcmcia_socket *s = to_socket(dev);
-       return sysfs_emit(buf, "%s\n", s->resource_setup_done ? "yes" : "no");
+       return sysfs_emit(buf, "%s\n", str_yes_no(s->resource_setup_done));
 }
 
 static ssize_t pccard_store_resource(struct device *dev,