library: remove unused module import

Move the import at the top of the file and remove unused module import.

- E402 module level import not at top of file
- F401 'xxxx' imported but unused

This also removes the '# noqa E402' statement from the code.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit 2138a00a3294b222d5e8325495300841ed5a7f5f)

diff --git a/library/ceph_dashboard_user.py b/library/ceph_dashboard_user.py
index 6f682a05ac69e149ce73c8092373cd4d85ae9b48..ba94f83bb7f8482fb2904489a85289f959a8d0ef 100644 (file)
--- a/library/ceph_dashboard_user.py
+++ b/library/ceph_dashboard_user.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -103,13 +108,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image, interactive=False):
     '''

diff --git a/library/ceph_fs.py b/library/ceph_fs.py
index 46413a02134c8ecea69dd1a46259ddc970901b89..942d618a48c2c14d8819c9c2506ea0c5c1397ed9 100644 (file)
--- a/library/ceph_fs.py
+++ b/library/ceph_fs.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -91,13 +96,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/ceph_key.py b/library/ceph_key.py
index d2bcf901321268ae1426707c0b168b1cde12a6c9..c8ec768fb27b569363377740a9bf3213132c3f00 100644 (file)
--- a/library/ceph_key.py
+++ b/library/ceph_key.py
@@ -17,6 +17,15 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+import struct
+import time
+import base64
+import socket
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -175,17 +184,6 @@ caps:
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import grp  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import pwd  # noqa: E402
-import stat  # noqa: E402
-import struct  # noqa: E402
-import time  # noqa: E402
-import base64  # noqa: E402
-import socket  # noqa: E402
 
 CEPH_INITIAL_KEYS = ['client.admin', 'client.bootstrap-mds', 'client.bootstrap-mgr',  # noqa: E501
                      'client.bootstrap-osd', 'client.bootstrap-rbd', 'client.bootstrap-rbd-mirror', 'client.bootstrap-rgw']  # noqa: E501

diff --git a/library/ceph_pool.py b/library/ceph_pool.py
index 05e8ee2c6b545532e05a9abce13a7722f91a0875..69804930e82948b5d561dc78ff6102608cad48b4 100644 (file)
--- a/library/ceph_pool.py
+++ b/library/ceph_pool.py
@@ -17,6 +17,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -135,13 +140,6 @@ pools:
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/ceph_volume.py b/library/ceph_volume.py
index eb7088c8d5d5ccf67ce58ac2fa9113087c712d93..7de6d8ee55c45bdd93ec3b3d52591530eb261689 100644 (file)
--- a/library/ceph_volume.py
+++ b/library/ceph_volume.py
@@ -1,5 +1,6 @@
 #!/usr/bin/python
 
+from ansible.module_utils.basic import AnsibleModule
 import datetime
 import copy
 import json
@@ -185,9 +186,6 @@ EXAMPLES = '''
 '''
 
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-
-
 def fatal(message, module):
     '''
     Report a fatal error and exit

diff --git a/library/radosgw_realm.py b/library/radosgw_realm.py
index 788ad1ea4a799b4a833d8f89363d0dff648eed3f..2823113882b1200a4211efc486c0215b9bf89a02 100644 (file)
--- a/library/radosgw_realm.py
+++ b/library/radosgw_realm.py
@@ -15,6 +15,10 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -81,13 +85,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/radosgw_user.py b/library/radosgw_user.py
index dc26708050983ee7f8a31a0cfb224668dd72582e..047040ac3ad224dd8667faba1aca0bdc9c1165b4 100644 (file)
--- a/library/radosgw_user.py
+++ b/library/radosgw_user.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -129,13 +134,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/radosgw_zone.py b/library/radosgw_zone.py
index 6184151bed6201dec37604d2cdd29a77caf6e8c5..23558befba6e4605e47322cab62f39a5f635600c 100644 (file)
--- a/library/radosgw_zone.py
+++ b/library/radosgw_zone.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -114,13 +119,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def fatal(message, module):
     '''

diff --git a/library/radosgw_zonegroup.py b/library/radosgw_zonegroup.py
index 0073d8d7ae62da385f582f02abadf5a2805adcab..1c8aeb33928d451e0d4deec234fc6066bbbb2cd7 100644 (file)
--- a/library/radosgw_zonegroup.py
+++ b/library/radosgw_zonegroup.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -101,13 +106,6 @@ EXAMPLES = '''
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''