]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
lint: variables should have spaces before and after
authorGuillaume Abrioux <gabrioux@redhat.com>
Fri, 2 Oct 2020 11:05:01 +0000 (13:05 +0200)
committerGuillaume Abrioux <gabrioux@redhat.com>
Mon, 23 Nov 2020 07:33:47 +0000 (08:33 +0100)
Fix ansible lint 206 error:

[206] Variables should have spaces before and after: {{ var_name }}

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
infrastructure-playbooks/purge-cluster.yml
infrastructure-playbooks/purge-iscsi-gateways.yml
infrastructure-playbooks/shrink-mgr.yml
infrastructure-playbooks/shrink-osd.yml
infrastructure-playbooks/shrink-rgw.yml
infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml

index 64157679500f75a074c1be515fdb2c282b13d6af..d0685d894c8f6c736a303c15cadd5f735a0d7c14 100644 (file)
 
   - name: stop ceph mgrs with systemd
     service:
-      name: ceph-mgr@{{ ansible_hostname}}
+      name: ceph-mgr@{{ ansible_hostname }}
       state: stopped
       enabled: no
     failed_when: false
 
   - name: stop ceph-osd with systemd
     service:
-      name: ceph-osd@{{item}}
+      name: ceph-osd@{{ item }}
       state: stopped
       enabled: no
     with_items: "{{ osd_ids.stdout_lines }}"
index 96b632a9eac3f9934f749d4c9779ab7b680c420e..9c478736e7900bca3a9104a04699fc364ed59dfa 100644 (file)
@@ -24,7 +24,7 @@
     - iscsigws
   become: yes
   vars:
-    - igw_purge_type: "{{hostvars['localhost']['igw_purge_type']}}"
+    - igw_purge_type: "{{ hostvars['localhost']['igw_purge_type'] }}"
 
   tasks:
     - name: stopping and disabling iscsi daemons
index c4fbc0f900476ce382e4e23241e511e2aa7e0a0e..2f77662fceb151e7e395204c9ec7b895facebf1a 100644 (file)
@@ -52,7 +52,7 @@
     - name: get total number of mgrs in cluster
       block:
         - name: save mgr dump output
-          command: "{{ container_exec_cmd | default('') }} ceph --cluster {{cluster}} mgr dump -f json"
+          command: "{{ container_exec_cmd | default('') }} ceph --cluster {{ cluster }} mgr dump -f json"
           register: mgr_dump
 
         - name: get active and standbys mgr list
index 31ddd20e0a8cb8a27b2ca743293f12c815d7e70a..516e95cbdf9b6828a931bd8026542e55c7b445ff 100644 (file)
 
     - name: add pkname information in ceph_osd_data_json
       set_fact:
-        ceph_osd_data_json: "{{ ceph_osd_data_json | default({}) | combine({item.item[2]: {'pkname_data': '/dev/' + item.stdout}}, recursive=True) }}"
+        ceph_osd_data_json: "{{ ceph_osd_data_json | default({}) | combine({item.item[2]: {'pkname_data': '/dev/' + item.stdout }}, recursive=True) }}"
       loop: "{{ parent_device_data_part.results }}"
       when: item.skipped is undefined
 
index 219ae310da2f5e0f396ecd2987d943154e09f53f..8c0902b6a9ea69deae043cf9507c7fb84c06b8f0 100644 (file)
       delegate_to: "{{ rgw_host }}"
   post_tasks:
     - name: show ceph health
-      command: "{{ container_exec_cmd | default('')}} ceph --cluster {{ cluster }} -s"
+      command: "{{ container_exec_cmd | default('') }} ceph --cluster {{ cluster }} -s"
       changed_when: false
index 4f54dac333aac3b567c965b8cb0e75d9b11594a6..8255aa90a2b5bb5c8d5f3fc958236f37a09b63ab 100644 (file)
       command: "systemctl disable --runtime {{ item }}"
       changed_when: false
       failed_when: false
-      with_items: "{{ running_osds.stdout_lines | default([])}}"
+      with_items: "{{ running_osds.stdout_lines | default([]) }}"
       when: item.startswith('ceph-osd@')
 
     - name: stop/disable/mask non-containerized ceph osd(s) (if any)
         name: "{{ item }}"
         state: stopped
         enabled: no
-      with_items: "{{ running_osds.stdout_lines | default([])}}"
+      with_items: "{{ running_osds.stdout_lines | default([]) }}"
       when: running_osds != []
 
     - name: remove old ceph-osd systemd units