]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mds/MDSMap: Enhance set_min_compat_client to validate iterator range before sorting...
authorEdwin Rodriguez <edwin.rodriguez1@ibm.com>
Thu, 7 Aug 2025 18:27:18 +0000 (14:27 -0400)
committerEdwin Rodriguez <edwin.rodriguez1@ibm.com>
Wed, 20 Aug 2025 12:35:52 +0000 (08:35 -0400)
Fixes: https://tracker.ceph.com/issues/72476
Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>
src/mds/MDSMap.cc

index 59f9c5a4da031f29b7841f079d2470e75930ff73..f7cec0e1a7b3d09120283e2a3f42d05761145117 100644 (file)
@@ -1331,7 +1331,14 @@ void MDSMap::set_min_compat_client(ceph_release_t version)
   else if (version >= ceph_release_t::jewel)
     bits.push_back(CEPHFS_FEATURE_JEWEL);
 
-  std::sort(bits.begin(), bits.end());
+  if (bits.size() >= 2) {  // Need at least 2 elements to sort
+    auto first = bits.begin();
+    auto last = bits.end();
+    if (first < last) {  // Validate iterator range
+      std::sort(first, last);
+    }
+  }
+
   required_client_features = feature_bitset_t(bits);
 }