]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
crimson/osd: slightly optimize OperationRegistryT::do_register()
authorRadosław Zarzyński <rzarzyns@redhat.com>
Mon, 11 Apr 2022 14:50:31 +0000 (16:50 +0200)
committerRadosław Zarzyński <rzarzyns@redhat.com>
Thu, 5 May 2022 02:06:31 +0000 (04:06 +0200)
There is no need to call the virtual op::get_type() twice.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
src/crimson/common/operation.h

index a8bcabf918ce8de2cb847938b259e6ee070977c7..a284037d4a36f29a36c64fac446f051d572f60ba 100644 (file)
@@ -486,8 +486,9 @@ class OperationRegistryT : public OperationRegistryI {
 
 protected:
   void do_register(Operation *op) final {
-    registries[op->get_type()].push_back(*op);
-    op->set_id(++op_id_counters[op->get_type()]);
+    const auto op_type = op->get_type();
+    registries[op_type].push_back(*op);
+    op->set_id(++op_id_counters[op_type]);
   }
 
   bool registries_empty() const final {