[RM-12553] Apt repo file mode 0600 when URL has pw

Signed-off-by: Travis Rhoden <trhoden@redhat.com>

diff --git a/ceph_deploy/util/pkg_managers.py b/ceph_deploy/util/pkg_managers.py
index c9bdefc355efba08af0ab60bf1abde4438f7cc5e..94fc1ad9a310259d6fdcf10c13959da5e062db14 100644 (file)
--- a/ceph_deploy/util/pkg_managers.py
+++ b/ceph_deploy/util/pkg_managers.py
@@ -400,10 +400,17 @@ class Apt(PackageManager):
             self.add_repo_gpg_key(gpg_url)
 
         safe_filename = '%s.list' % name.replace(' ', '-')
+        mode = 0644
+        if urlparse(url).password:
+            mode = 0600
+            self.remote_conn.logger.info(
+                "Creating repo file with mode 0600 due to presence of password"
+            )
         self.remote_conn.remote_module.write_sources_list(
             url,
             self.remote_info.codename,
-            safe_filename
+            safe_filename,
+            mode
         )
 
         # Add package pinning for this repo