xfs_scrub: don't leak the autofsck fsproperty handle

Codex notices that we leak the fsproperty handle if the filesystem
doesn't actually have the property set.  Fix that by moving the free
call; it can handle a totally nulled out structure.

Cc: linux-xfs@vger.kernel.org # v6.10.0
Fixes: 9451b5ee0d0d2d ("xfs_scrub: allow sysadmin to control background scrubs")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>

diff --git a/scrub/phase1.c b/scrub/phase1.c
index 6ac59264b50bb7e590012364d4e0e975c60fc995..620a12393b3658e0431406eb628558db1923b884 100644 (file)
--- a/scrub/phase1.c
+++ b/scrub/phase1.c
@@ -178,8 +178,6 @@ mode_from_autofsck(
                break;
        }
 
-       fsprops_free_handle(&fph);
-
 summarize:
        switch (ctx->mode) {
        case SCRUB_MODE_NONE:
@@ -200,6 +198,7 @@ summarize:
                break;
        }
 
+       fsprops_free_handle(&fph);
        return;
 no_property:
        /*