]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
Merge PR #36097 into master
authorPatrick Donnelly <pdonnell@redhat.com>
Sat, 18 Jul 2020 03:28:50 +0000 (20:28 -0700)
committerPatrick Donnelly <pdonnell@redhat.com>
Sat, 18 Jul 2020 03:28:50 +0000 (20:28 -0700)
* refs/pull/36097/head:
mds: fix nullptr dereference in MDCache::finish_rollback

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
1  2 
src/mds/MDCache.cc

index 28a7e2b7ae8707d99d4cd3021a9dd4475a4df62e,f6ba2d4aacb62f8f01804e8ad6cfc95e7af78306..8ffca3d2b9c86b65d57210fc4ea8c75c6c183860
@@@ -3605,15 -3605,15 +3605,15 @@@ MDPeerUpdate* MDCache::get_uncommitted_
  }
  
  void MDCache::finish_rollback(metareqid_t reqid, MDRequestRef& mdr) {
-   auto p = resolve_need_rollback.find(mdr->reqid);
+   auto p = resolve_need_rollback.find(reqid);
    ceph_assert(p != resolve_need_rollback.end());
    if (mds->is_resolve()) {
 -    finish_uncommitted_slave(reqid, false);
 +    finish_uncommitted_peer(reqid, false);
    } else if (mdr) {
 -    finish_uncommitted_slave(mdr->reqid, mdr->more()->slave_update_journaled);
 +    finish_uncommitted_peer(mdr->reqid, mdr->more()->peer_update_journaled);
    }
    resolve_need_rollback.erase(p);
 -  maybe_finish_slave_resolve();
 +  maybe_finish_peer_resolve();
  }
  
  void MDCache::disambiguate_other_imports()