]> git.apps.os.sepia.ceph.com Git - teuthology.git/commitdiff
PhysicalConsole: Correctly report power_on failure
authorZack Cerza <zack@redhat.com>
Tue, 5 Dec 2017 17:57:43 +0000 (10:57 -0700)
committerZack Cerza <zack@redhat.com>
Tue, 5 Dec 2017 17:57:43 +0000 (10:57 -0700)
We've been logging an error, then unconditionally reporting success. Fix
it.

Signed-off-by: Zack Cerza <zack@redhat.com>
teuthology/orchestra/console.py

index c15e02b0fc9b26843d627666294a8b333c7964f4..f2111077463f5cefde99c95dd71d04751700976e 100644 (file)
@@ -228,9 +228,10 @@ class PhysicalConsole():
                              timeout=self.timeout)
             if r == 0:
                 break
-        if not self.check_power('on'):
+        if self.check_power('on'):
+            log.info('Power on for {s} completed'.format(s=self.shortname))
+        else:
             log.error('Failed to power on {s}'.format(s=self.shortname))
-        log.info('Power on for {s} completed'.format(s=self.shortname))
 
     def power_off(self):
         """