]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
rgw: Silence maybe-uninitialized false positives
authorBrad Hubbard <bhubbard@redhat.com>
Fri, 1 Dec 2017 05:47:58 +0000 (15:47 +1000)
committerBrad Hubbard <bhubbard@redhat.com>
Fri, 15 Dec 2017 07:18:37 +0000 (17:18 +1000)
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
src/rgw/rgw_sync_log_trim.cc

index 418441996f2b47fe6f878416a741cac7bae1f618..fb95f4bc01c2cab92440cbf7c8046c0557a19029 100644 (file)
@@ -347,7 +347,9 @@ int take_min_status(CephContext *cct, Iter first, Iter last,
                     std::vector<std::string> *status)
 {
   status->clear();
-  boost::optional<size_t> num_shards;
+  // The initialisation below is required to silence a false positive
+  // -Wmaybe-uninitialized warning
+  boost::optional<size_t> num_shards = boost::make_optional(false, 0UL);
   for (auto peer = first; peer != last; ++peer) {
     const size_t peer_shards = peer->size();
     if (!num_shards) {
@@ -417,6 +419,7 @@ class BucketTrimInstanceCR : public RGWCoroutine {
   std::string bucket_instance;
   const std::string& zone_id; //< my zone id
   RGWBucketInfo bucket_info; //< bucket instance info to locate bucket indices
+  int child_ret = 0;
 
   using StatusShards = std::vector<rgw_bucket_shard_sync_info>;
   std::vector<StatusShards> peer_status; //< sync status for each peer
@@ -467,7 +470,6 @@ int BucketTrimInstanceCR::operate()
     }
     // wait for a response from each peer. all must respond to attempt trim
     while (num_spawned()) {
-      int child_ret;
       yield wait_for_child();
       collect(&child_ret, nullptr);
       if (child_ret < 0) {