]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
fstests: get section config after RUN_SECTION checks v2022.10.16
authorJosef Bacik <josef@toxicpanda.com>
Wed, 24 Aug 2022 19:32:10 +0000 (15:32 -0400)
committerZorro Lang <zlang@kernel.org>
Sun, 16 Oct 2022 07:00:05 +0000 (15:00 +0800)
While trying to do

./check -s <some section>

I was failing because I had a section defined higher than <some section>
that had TEST_DEV=/some/nonexistent/device, since I was using the other
section to test an experimental drive.  This appears to be because we
run through all of the sections, and when getting the section config we
check to see if it's valid, and in this case the section wasn't valid.

The section I was actually trying to use was valid however.  Fix check
to see if the section we're trying to run is in our list of sections to
run first, and then if it is get the config at that point.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
check

diff --git a/check b/check
index a880d52f500090776173cd7c5f83e955bf45bb35..d2e5129620bd630cdf75a6dcd1ac1457cedb14dc 100755 (executable)
--- a/check
+++ b/check
@@ -678,7 +678,6 @@ function run_section()
 
        OLD_FSTYP=$FSTYP
        OLD_TEST_FS_MOUNT_OPTS=$TEST_FS_MOUNT_OPTS
-       get_next_config $section
 
        # Do we need to run only some sections ?
        if [ ! -z "$RUN_SECTION" ]; then
@@ -708,6 +707,8 @@ function run_section()
                fi
        fi
 
+       get_next_config $section
+
        mkdir -p $RESULT_BASE
        if [ ! -d $RESULT_BASE ]; then
                echo "failed to create results directory $RESULT_BASE"