tests/*/Makefile: make sure group.list DIRT exists before install

* sometimes make install was failing with:
  cp: cannot stat 'group.list': No such file or directory
  and bunch of non-fatal messages:
  mv: failed to preserve ownership for 'group.list': Invalid argument

* this was when tools/mkgroupfile did
  mv -f "$new_groups" "$groupfile"
  overwritting the group.list file while install-sh was already
  copying it to output

* in the end easily reproducible by
  1) removing tests/*/group.list before each make install
  2) adding some sleep in mkgroupfile before the mv call

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>

diff --git a/tests/btrfs/Makefile b/tests/btrfs/Makefile
index 1b72a1a16fab8e703534a5f10078d9639b55fdc6..6d9995b4abb2755e55b14c900bca04ea16176afa 100644 (file)
--- a/tests/btrfs/Makefile
+++ b/tests/btrfs/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/ceph/Makefile b/tests/ceph/Makefile
index 2761e1e9971b017e689c6cc7b0f9a3fcd899dc3a..5f24d51803ab82a6b8e07e95c01d50c14004ec43 100644 (file)
--- a/tests/ceph/Makefile
+++ b/tests/ceph/Makefile
@@ -12,7 +12,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/cifs/Makefile b/tests/cifs/Makefile
index 62c489352d739aca357c6ba01071300b2f8465fe..0b89a01d33a67e3f0010308bcf4e7198f7f6cc38 100644 (file)
--- a/tests/cifs/Makefile
+++ b/tests/cifs/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/ext4/Makefile b/tests/ext4/Makefile
index a2a0d56116ea80990f20300104474a7a507b2bdb..296e3850b714f937098370f43c2710442fdc5092 100644 (file)
--- a/tests/ext4/Makefile
+++ b/tests/ext4/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/f2fs/Makefile b/tests/f2fs/Makefile
index 9d1ed3c639c1e2a472cbae2aa55500b8a7e4fb75..0a90b4652ea925111dfec7b86d85ef7003f08f4b 100644 (file)
--- a/tests/f2fs/Makefile
+++ b/tests/f2fs/Makefile
@@ -15,7 +15,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/generic/Makefile b/tests/generic/Makefile
index b464b22b4c70e5c2950f3a6a366a3099e9e5410f..d6ed3e55d7df2769c27db792e0514b8af3678e5b 100644 (file)
--- a/tests/generic/Makefile
+++ b/tests/generic/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/nfs/Makefile b/tests/nfs/Makefile
index 128d2a3a79e7e659be6b4f651a52758769f1763d..51590b5ce518da1a2e88b137d3c622ec4bea0647 100644 (file)
--- a/tests/nfs/Makefile
+++ b/tests/nfs/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/ocfs2/Makefile b/tests/ocfs2/Makefile
index 260ad31bdc9f87aba262c8864ad77eaa30b69958..17e01bf38b94ecd3d088d59e1920ab77cc187f66 100644 (file)
--- a/tests/ocfs2/Makefile
+++ b/tests/ocfs2/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/overlay/Makefile b/tests/overlay/Makefile
index 2785b94d9485634bb231ccc27f7e3db91e6ab684..c71e78d615d6a0c49ecc2b6ee7255fa2a248af90 100644 (file)
--- a/tests/overlay/Makefile
+++ b/tests/overlay/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/perf/Makefile b/tests/perf/Makefile
index 0c74ba393d2a2bdabfee8ea0c590441ae65d3b07..d72c04d95d9f96d7366dd7dae319fc801e6e6982 100644 (file)
--- a/tests/perf/Makefile
+++ b/tests/perf/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/selftest/Makefile b/tests/selftest/Makefile
index 3ddfca3745c01307cd6f11f453629570d8e8616c..cabc35a9a217ee25c52e3f9f258d2addd0d69ffb 100644 (file)
--- a/tests/selftest/Makefile
+++ b/tests/selftest/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/shared/Makefile b/tests/shared/Makefile
index f312871412a5484acad8e9d5a7bf9bc31d5f6e0e..2e6aa718446171a2403f8e8ebb9a0bc202bf8ee4 100644 (file)
--- a/tests/shared/Makefile
+++ b/tests/shared/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/tmpfs/Makefile b/tests/tmpfs/Makefile
index 465443136330c052b3e16a2443869ec25d3f98b4..46b62dad3f3358a59c74921dd4fa59fe83449dcc 100644 (file)
--- a/tests/tmpfs/Makefile
+++ b/tests/tmpfs/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/udf/Makefile b/tests/udf/Makefile
index ed4434f0ba59864d214f2210fae30597c69a0cdc..feda69a66201e33a498a24c7443423adb64d366e 100644 (file)
--- a/tests/udf/Makefile
+++ b/tests/udf/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)

diff --git a/tests/xfs/Makefile b/tests/xfs/Makefile
index 5f413e67a4c80c3c8734e4b922e3d90567f5d4b3..6bfafdb16393a42b821a3ac47a311f27a36401e9 100644 (file)
--- a/tests/xfs/Makefile
+++ b/tests/xfs/Makefile
@@ -14,7 +14,7 @@ default: $(DIRT)
 
 include $(BUILDRULES)
 
-install:
+install: default
        $(INSTALL) -m 755 -d $(TARGET_DIR)
        $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
        $(INSTALL) -m 644 group.list $(TARGET_DIR)