]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
common/options: update mon_crush_min_required_version=hammer
authorSage Weil <sage@redhat.com>
Fri, 12 Apr 2019 21:35:18 +0000 (16:35 -0500)
committerSage Weil <sage@redhat.com>
Fri, 12 Apr 2019 21:35:18 +0000 (16:35 -0500)
Hammer is a good point to set the minimum at:

 - it includes straw2 and vary_r, which are the worst offenders among the
   old tunables
 - it does not include chooseleaf_stable, which improves placement
   considerably but *also* shuffles basically all data in the cluster.

Getting everyone up to straw2 support means we can also proscribe the
'ceph osd crush set-all-straw-buckets-to-straw2' command.

Signed-off-by: Sage Weil <sage@redhat.com>
src/common/options.cc

index 36ed0fbb355fdf1c88fac8bb80f275ba9b94f7a9..9df8163549a593ad03f377a68bc3083f049e5a6e 100644 (file)
@@ -1572,7 +1572,7 @@ std::vector<Option> get_global_options() {
     .add_see_also("mon_crush_min_required_version"),
 
     Option("mon_crush_min_required_version", Option::TYPE_STR, Option::LEVEL_ADVANCED)
-    .set_default("firefly")
+    .set_default("hammer")
     .add_service("mgr")
     .set_description("minimum ceph release to use for mon_warn_on_legacy_crush_tunables")
     .add_see_also("mon_warn_on_legacy_crush_tunables"),