]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
Merge pull request #13918 from liupan1111/wip-fix-performance-filestore
authorKefu Chai <tchaikov@gmail.com>
Wed, 5 Jul 2017 07:00:44 +0000 (15:00 +0800)
committerGitHub <noreply@github.com>
Wed, 5 Jul 2017 07:00:44 +0000 (15:00 +0800)
os/filestore: queue ondisk completion before apply work

Reviewed-by: Sage Weil <sage@redhat.com>
1  2 
src/os/filestore/FileStore.cc

index b6b809aff9c32b0eaefc5d9d0aa5a87dab571d9d,2ce58f5a53ba85e583d6725c1f1a64a1f99b1d23..1d018f3eaf8a222a5460c107bbc810753a4a5d8f
@@@ -2266,16 -2213,8 +2266,10 @@@ int FileStore::queue_transactions(Seque
  
  void FileStore::_journaled_ahead(OpSequencer *osr, Op *o, Context *ondisk)
  {
 -  dout(5) << "_journaled_ahead " << o << " seq " << o->op << " " << *osr << " " << o->tls << dendl;
 +  dout(5) << __FUNC__ << ": " << o << " seq " << o->op << " " << *osr << " " << o->tls << dendl;
 +
 +  o->trace.event("writeahead journal finished");
  
-   // this should queue in order because the journal does it's completions in order.
-   queue_op(osr, o);
-   list<Context*> to_queue;
-   osr->dequeue_journal(&to_queue);
    // do ondisk completions async, to prevent any onreadable_sync completions
    // getting blocked behind an ondisk completion.
    if (ondisk) {