]> git-server-git.apps.pok.os.sepia.ceph.com Git - s3-tests.git/commitdiff
Make queue and name arguments not optional; they're always passed in anyway.
authorTommi Virtanen <tommi.virtanen@dreamhost.com>
Wed, 20 Jul 2011 16:53:26 +0000 (09:53 -0700)
committerTommi Virtanen <tommi.virtanen@dreamhost.com>
Wed, 20 Jul 2011 18:06:30 +0000 (11:06 -0700)
s3tests/rand_readwrite.py

index df5a92968a051b732ec94cbd862a6b79cef5b1ae..a86dd25fd58a3c329d940d4ff5a7de436e62c7a0 100644 (file)
@@ -48,7 +48,7 @@ class Result:
             details=self.details,
             )
 
-def reader(bucket, name=None, queue=None):
+def reader(bucket, name, queue):
     while (1):
         count = 0
         for key in bucket.list():
@@ -57,21 +57,20 @@ def reader(bucket, name=None, queue=None):
             key.get_contents_to_file(fp)
             end = time.time()
             elapsed = end - start
-            if queue:
-                queue.put(
-                    Result(
-                        name,
-                        type=Result.TYPE_READER,
-                        time=elapsed,
-                        success=fp.valid(),
-                        size=fp.size / 1024,
-                        ),
-                    )
+            queue.put(
+                Result(
+                    name,
+                    type=Result.TYPE_READER,
+                    time=elapsed,
+                    success=fp.valid(),
+                    size=fp.size / 1024,
+                    ),
+                )
             count += 1
         if count == 0:
             gevent.sleep(1)
 
-def writer(bucket, name=None, queue=None, quantity=1, file_size=1, file_stddev=0, file_name_seed=None):
+def writer(bucket, name, queue, quantity=1, file_size=1, file_stddev=0, file_name_seed=None):
     while (1):
         r = random.randint(0, 65535)
         r2 = r
@@ -90,13 +89,12 @@ def writer(bucket, name=None, queue=None, quantity=1, file_size=1, file_stddev=0
         end = time.time()
         elapsed = end - start
 
-        if queue:
-            queue.put(Result(name,
-                type=Result.TYPE_WRITER,
-                time=elapsed,
-                size=sum(f.size/1024 for f in files),
-                )
+        queue.put(Result(name,
+            type=Result.TYPE_WRITER,
+            time=elapsed,
+            size=sum(f.size/1024 for f in files),
             )
+        )
 
 def parse_options():
     parser = optparse.OptionParser()