]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfsprogs-dev.git/commitdiff
xfs_repair: don't flag RTINHERIT files when no rt volume xfsprogs-5.9-fixes2_2020-09-17
authorDarrick J. Wong <darrick.wong@oracle.com>
Mon, 14 Sep 2020 17:39:32 +0000 (10:39 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 18 Sep 2020 02:03:33 +0000 (19:03 -0700)
Don't flag directories with the RTINHERIT flag set when the filesystem
doesn't have a realtime volume configured.  The kernel has let us set
RTINHERIT without a rt volume for ages, so it's not an invalid state.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
repair/dinode.c

index 48b75f7883c53a2134f65f5ae3ab03e3247e8a0b..8aee9f9e83432f59c353285b0c0bf8324f1fd056 100644 (file)
@@ -2393,17 +2393,14 @@ _("bad (negative) size %" PRId64 " on inode %" PRIu64 "\n"),
                        flags &= XFS_DIFLAG_ANY;
                }
 
-               if (flags & (XFS_DIFLAG_REALTIME | XFS_DIFLAG_RTINHERIT)) {
-                       /* need an rt-dev! */
-                       if (!rt_name) {
-                               if (!uncertain) {
-                                       do_warn(
+               /* need an rt-dev for the realtime flag! */
+               if ((flags & XFS_DIFLAG_REALTIME) && !rt_name) {
+                       if (!uncertain) {
+                               do_warn(
        _("inode %" PRIu64 " has RT flag set but there is no RT device\n"),
-                                               lino);
-                               }
-                               flags &= ~(XFS_DIFLAG_REALTIME |
-                                               XFS_DIFLAG_RTINHERIT);
+                                       lino);
                        }
+                       flags &= ~XFS_DIFLAG_REALTIME;
                }
                if (flags & XFS_DIFLAG_NEWRTBM) {
                        /* must be a rt bitmap inode */