osd: fix logic in check_pg_upmaps

The logic was changed in check_pg_upmaps
in a Reef refactor, which results in recommendations
made by the upmap balancer even when it says there are
no optimizations.

Fixes: https://tracker.ceph.com/issues/63029
Signed-off-by: Laura Flores <lflores@ibm.com>

diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc
index 4a2d400b6703486e387599c17125204a9569341b..ce199e8ee8ac6eff0b5be411a0ef169c69f09eae 100644 (file)
--- a/src/osd/OSDMap.cc
+++ b/src/osd/OSDMap.cc
@@ -2157,8 +2157,8 @@ bool OSDMap::check_pg_upmaps(
                        << j->first << " " << j->second
                        << dendl;
         to_cancel->push_back(pg);
-      } else {
-        //Josh--check partial no-op here.
+      } else if (newmap != j->second) {
+        // check partial no-op here.
         ldout(cct, 10) << __func__ << " simplifying partially no-op pg_upmap_items "
                        << j->first << " " << j->second
                        << " -> " << newmap