]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Fix more signed-unsigned comparisons
authorMayank Agarwal <amayank@fb.com>
Tue, 19 Mar 2013 21:53:22 +0000 (14:53 -0700)
committerMayank Agarwal <amayank@fb.com>
Wed, 20 Mar 2013 00:21:36 +0000 (17:21 -0700)
Summary: Some comparisons left in log_test.cc and db_test.cc complained by make

Test Plan: make

Reviewers: dhruba, sheki

Reviewed By: dhruba

Differential Revision: https://reviews.facebook.net/D9537

db/db_test.cc
db/log_test.cc

index dc069a89213986989c6b8b9e7c7c0d2c14b59e67..a9c83a7a49c112f706921e93bd182cd92999364d 100644 (file)
@@ -1480,7 +1480,7 @@ TEST(DBTest, CompactionFilter) {
   while (iter->Valid()) {
     ParsedInternalKey ikey;
     ASSERT_EQ(ParseInternalKey(iter->key(), &ikey), true);
-    ASSERT_NE(ikey.sequence, 0);
+    ASSERT_NE(ikey.sequence, (unsigned)0);
     count++;
     iter->Next();
   }
index 1840090b387a48f603ebb1a8cc59590f7c44c364..367e2f18ce03015b0ba367e538fed7fb85773ab5 100644 (file)
@@ -450,13 +450,13 @@ TEST(LogTest, ErrorJoinsRecords) {
   Write("correct");
 
   // Wipe the middle block
-  for (int offset = kBlockSize; offset < 2*kBlockSize; offset++) {
+  for (unsigned int offset = kBlockSize; offset < 2*kBlockSize; offset++) {
     SetByte(offset, 'x');
   }
 
   ASSERT_EQ("correct", Read());
   ASSERT_EQ("EOF", Read());
-  const int dropped = DroppedBytes();
+  const unsigned int dropped = DroppedBytes();
   ASSERT_LE(dropped, 2*kBlockSize + 100);
   ASSERT_GE(dropped, 2*kBlockSize);
 }