ceph-mds: fix the handler

Moving the mds_name fact in the common role so the MDS can properly
be restarted.

Signed-off-by: Sébastien Han <seb@redhat.com>

diff --git a/group_vars/all.sample b/group_vars/all.sample
index ab36dc184e27721c0a1f197714d3feb9811d7f2f..fbde88744b1bfaf4d30c4c131857fb155419ef9b 100644 (file)
--- a/group_vars/all.sample
+++ b/group_vars/all.sample
@@ -314,6 +314,7 @@ dummy:
 ## MDS options
 #
 #mds_use_fqdn: false # if set to true, the MDS name used will be the fqdn in the ceph.conf
+#mds_name: "{{ ansible_hostname }}"
 
 ## Rados Gateway options
 #
@@ -392,3 +393,4 @@ dummy:
 # by ceph.conf.j2 template. so it should always be defined
 #mon_containerized_deployment_with_kv: false
 
+

diff --git a/group_vars/common-coreoss.sample b/group_vars/common-coreoss.sample
index 32ae29553386d62055e4d83f38254a62dcb15692..071f0af9e74c82368cd1cfe55df29618c2634d21 100644 (file)
--- a/group_vars/common-coreoss.sample
+++ b/group_vars/common-coreoss.sample
@@ -14,4 +14,3 @@ dummy:
 #pypy_binary_directory: /opt/bin
 #pip_url: https://bootstrap.pypa.io/get-pip.py
 #local_temp_directory: /tmp
-

diff --git a/roles/ceph-common/tasks/facts.yml b/roles/ceph-common/tasks/facts.yml
index d65fa2f363ae47fbd079aa563a42f29b0773ef17..b1cd054f58b160e34088a09be2e2b6922fb7c27c 100644 (file)
--- a/roles/ceph-common/tasks/facts.yml
+++ b/roles/ceph-common/tasks/facts.yml
@@ -61,3 +61,12 @@
 
 - set_fact:
     is_kraken={{ ceph_version | version_compare('11.0.0', '>=')  and ceph_version | version_compare('12.0.0', '<') }}
+
+- set_fact:
+    mds_name: "{{ ansible_hostname }}"
+  when: not mds_use_fqdn
+
+- set_fact:
+    mds_name: "{{ ansible_fqdn }}"
+  when: mds_use_fqdn
+

diff --git a/roles/ceph-mds/tasks/pre_requisite.yml b/roles/ceph-mds/tasks/pre_requisite.yml
index cd16d76fa2fbe1937c271dab25c0f3ec9db447e2..4b24ea5e02ccf7175d0e52f08b86d10620acfaee 100644 (file)
--- a/roles/ceph-mds/tasks/pre_requisite.yml
+++ b/roles/ceph-mds/tasks/pre_requisite.yml
@@ -1,12 +1,4 @@
 ---
-- set_fact:
-    mds_name: "{{ ansible_hostname }}"
-  when: not mds_use_fqdn
-
-- set_fact:
-    mds_name: "{{ ansible_fqdn }}"
-  when: mds_use_fqdn
-
 - name: create bootstrap-mds directory
   file:
     path: /var/lib/ceph/bootstrap-mds/