]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/cephadm: use ==/!= to compare constant literals (F632)
authorMichael Fritch <mfritch@suse.com>
Thu, 28 Jan 2021 18:24:57 +0000 (11:24 -0700)
committerMichael Fritch <mfritch@suse.com>
Fri, 5 Feb 2021 18:20:56 +0000 (11:20 -0700)
Signed-off-by: Michael Fritch <mfritch@suse.com>
src/pybind/mgr/cephadm/tests/test_cephadm.py
src/pybind/mgr/tox.ini

index fe1d53366267a4339c47a9396f2164a388e19149..0603720d2a48745770f331aaeed6c5df235a15c1 100644 (file)
@@ -835,13 +835,13 @@ class TestCephadm(object):
                 with with_host(cephadm_module, 'test', refresh_hosts=False):
                     code, out, err = cephadm_module.check_host('test')
                     # First should succeed.
-                    assert err is ''
+                    assert err == ''
 
                     # On second it should attempt to reuse the connection, where the
                     # connection is "down" so will recreate the connection. The old
                     # code will blow up here triggering the BOOM!
                     code, out, err = cephadm_module.check_host('test')
-                    assert err is ''
+                    assert err == ''
 
     @mock.patch("cephadm.module.CephadmOrchestrator._get_connection")
     @mock.patch("remoto.process.check")
index cb88ec4d0e67ef6b74beeaa029bc0c45af4237a6..5334020eb334cf6b136c9e438e7e9018a99cd670 100644 (file)
@@ -13,7 +13,6 @@ max-line-length = 100
 ignore =
     E501,
     F401,
-    F632,
     F811,
     F821,
     F841,