]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
cephadm-adopt: custom prometheus port lost after adoption
authorTeoman ONAY <tonay@ibm.com>
Wed, 2 Oct 2024 14:36:31 +0000 (16:36 +0200)
committerTeoman ONAY <tonay@ibm.com>
Mon, 14 Oct 2024 08:33:53 +0000 (10:33 +0200)
If a custom Prometheus port was used before adoption, it was not
taken into account and default 9095 was set instead. Now custom
port is re-applied.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2242346
Signed-off-by: Teoman ONAY <tonay@ibm.com>
infrastructure-playbooks/cephadm-adopt.yml

index 8fb2beba709733cd1b37f24a63e6c281d7a67562..2ecf68dbdf9a02780b2ad44608d3afb6e394be34 100644 (file)
             CEPHADM_IMAGE: '{{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }}'
 
         - name: Update the placement of prometheus hosts
-          ansible.builtin.command: "{{ cephadm_cmd }} shell -k /etc/ceph/{{ cluster }}.client.admin.keyring --fsid {{ fsid }} -- ceph orch apply prometheus --placement='{{ groups.get(monitoring_group_name, []) | length }} label:{{ monitoring_group_name }}'"
+          ceph_orch_apply:
+            fsid: "{{ fsid }}"
+            spec: |
+              service_name: prometheus
+              service_id: "{{ ansible_facts['hostname'] }}"
+              placement:
+                label: {{ monitoring_group_name }}
+                count: {{ groups.get(monitoring_group_name, []) | length }}
+              {% if prometheus_port is defined and prometheus_port != 9095 %}
+              spec:
+                port: {{ prometheus_port }}
+              {% endif %}
           changed_when: false
           environment:
             CEPHADM_IMAGE: '{{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }}'